Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in predictive methods of ParetoNBD model with covariates #589

Merged
merged 2 commits into from
Mar 15, 2024

Conversation

ricardoV94
Copy link
Contributor

@ricardoV94 ricardoV94 commented Mar 15, 2024

Description

Related Issue

  • Closes #
  • Related to #

Checklist

Modules affected

  • MMM
  • CLV

Type of change

  • New feature / enhancement
  • Bug fix
  • Documentation
  • Maintenance
  • Other (please specify):

📚 Documentation preview 📚: https://pymc-marketing--589.org.readthedocs.build/en/589/

@ricardoV94 ricardoV94 added bug Something isn't working CLV labels Mar 15, 2024
Copy link

codecov bot commented Mar 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.44%. Comparing base (d9c19c4) to head (a95874e).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #589   +/-   ##
=======================================
  Coverage   91.43%   91.44%           
=======================================
  Files          21       21           
  Lines        2137     2139    +2     
=======================================
+ Hits         1954     1956    +2     
  Misses        183      183           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ricardoV94 ricardoV94 changed the title Make data optional in all ParetoNBD methods Fix bug in predictive methods of ParetoNBD model with covariates Mar 15, 2024
@ricardoV94 ricardoV94 merged commit 10c8dc2 into pymc-labs:main Mar 15, 2024
10 checks passed
@ricardoV94 ricardoV94 deleted the patch_make_data_really_optional branch March 15, 2024 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CLV
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants