-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add other nuts samplers example notebook #579
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #579 +/- ##
==========================================
+ Coverage 91.04% 91.09% +0.05%
==========================================
Files 21 21
Lines 1999 2056 +57
==========================================
+ Hits 1820 1873 +53
- Misses 179 183 +4 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Only think I might add would be to actually time the sampling. Just to prove to the users that it's faster. I don't see a progressbar in the rendered docs
I just wanted to wide some numba warnings and messages which might distract the target audience. Just to keep it simple. |
If you are using vscode check the cell options and click "add tag" and simply write "hide-input" in the pop-out window , see https://myst-nb.readthedocs.io/en/latest/render/hiding.html :) |
Sounds good. Lgtm! |
* other nuts sampler init * clean directories * fix toctree * add nutpie * gpu comment * feedback
Closes #577
This should help users use other samplers which generally speed inference.
📚 Documentation preview 📚: https://pymc-marketing--579.org.readthedocs.build/en/579/