Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add other nuts samplers example notebook #579

Merged
merged 6 commits into from
Mar 10, 2024
Merged

Add other nuts samplers example notebook #579

merged 6 commits into from
Mar 10, 2024

Conversation

juanitorduz
Copy link
Collaborator

@juanitorduz juanitorduz commented Mar 8, 2024

Closes #577

This should help users use other samplers which generally speed inference.


📚 Documentation preview 📚: https://pymc-marketing--579.org.readthedocs.build/en/579/

@juanitorduz juanitorduz self-assigned this Mar 8, 2024
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@juanitorduz juanitorduz marked this pull request as draft March 8, 2024 15:04
@juanitorduz juanitorduz added the docs Improvements or additions to documentation label Mar 8, 2024
Copy link

codecov bot commented Mar 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.09%. Comparing base (9d8dab3) to head (e53878a).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #579      +/-   ##
==========================================
+ Coverage   91.04%   91.09%   +0.05%     
==========================================
  Files          21       21              
  Lines        1999     2056      +57     
==========================================
+ Hits         1820     1873      +53     
- Misses        179      183       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@juanitorduz juanitorduz marked this pull request as ready for review March 8, 2024 20:45
@juanitorduz juanitorduz added the enhancement New feature or request label Mar 8, 2024
@juanitorduz juanitorduz requested a review from twiecki March 9, 2024 19:02
@juanitorduz juanitorduz requested a review from wd60622 March 9, 2024 19:35
Copy link
Contributor

@wd60622 wd60622 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Only think I might add would be to actually time the sampling. Just to prove to the users that it's faster. I don't see a progressbar in the rendered docs

@wd60622
Copy link
Contributor

wd60622 commented Mar 9, 2024

Side question: How do you get the collapsible section from the notebook? I don't see anything signifying that in the notebook...
Screenshot 2024-03-09 at 20 41 11

@juanitorduz
Copy link
Collaborator Author

Looks great! Only think I might add would be to actually time the sampling. Just to prove to the users that it's faster. I don't see a progressbar in the rendered docs

I just wanted to wide some numba warnings and messages which might distract the target audience. Just to keep it simple.

@juanitorduz
Copy link
Collaborator Author

Side question: How do you get the collapsible section from the notebook? I don't see anything signifying that in the notebook... Screenshot 2024-03-09 at 20 41 11

If you are using vscode check the cell options and click "add tag" and simply write "hide-input" in the pop-out window , see https://myst-nb.readthedocs.io/en/latest/render/hiding.html :)

@wd60622
Copy link
Contributor

wd60622 commented Mar 9, 2024

I just wanted to wide some numba warnings and messages which might distract the target audience. Just to keep it simple.

Sounds good. Lgtm!

@twiecki twiecki merged commit 2aea494 into main Mar 10, 2024
9 checks passed
@twiecki twiecki deleted the other_samplers branch March 10, 2024 04:25
@ricardoV94 ricardoV94 removed the enhancement New feature or request label Mar 15, 2024
wd60622 pushed a commit that referenced this pull request Apr 8, 2024
* other nuts sampler init

* clean directories

* fix toctree

* add nutpie

* gpu comment

* feedback
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a new "General/Misc" sub-section to Examples for cross-model-class features
4 participants