Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move watermark in environment.yml #574

Merged
merged 2 commits into from
Mar 8, 2024
Merged

Move watermark in environment.yml #574

merged 2 commits into from
Mar 8, 2024

Conversation

juanitorduz
Copy link
Collaborator

@juanitorduz juanitorduz commented Mar 7, 2024

Add watermark package for nb versioning.

Shall we run all notebooks before a release to make sure they all work?


📚 Documentation preview 📚: https://pymc-marketing--574.org.readthedocs.build/en/574/

Copy link

codecov bot commented Mar 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.04%. Comparing base (9d8dab3) to head (dbf5bfd).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #574   +/-   ##
=======================================
  Coverage   91.04%   91.04%           
=======================================
  Files          21       21           
  Lines        1999     1999           
=======================================
  Hits         1820     1820           
  Misses        179      179           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@wd60622 wd60622 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to already be there. Maybe move to the appropriate section

remove duplicates
@juanitorduz juanitorduz changed the title Update environment.yml Move watermark in environment.yml Mar 8, 2024
@juanitorduz juanitorduz requested a review from wd60622 March 8, 2024 08:52
Copy link
Contributor

@wd60622 wd60622 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@juanitorduz juanitorduz merged commit be423bd into main Mar 8, 2024
9 checks passed
@juanitorduz juanitorduz deleted the watermark_to_env branch March 8, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants