Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix repr error when CLVModel is not yet built #563

Merged
merged 1 commit into from
Mar 1, 2024

Conversation

ricardoV94
Copy link
Contributor

@ricardoV94 ricardoV94 commented Mar 1, 2024

Description

The reason for separating model definition and model building in ModelBuilder is still elusive to me (cc @twiecki), but anyway this fixes the assumption that used to be true for CLVModels prior to them inheriting ModelBuilder

Related Issue

Checklist

Modules affected

  • MMM
  • CLV

Type of change

  • New feature / enhancement
  • Bug fix
  • Documentation
  • Maintenance
  • Other (please specify):

📚 Documentation preview 📚: https://pymc-marketing--563.org.readthedocs.build/en/563/

@ricardoV94 ricardoV94 added bug Something isn't working CLV model builder labels Mar 1, 2024
Copy link

codecov bot commented Mar 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.37%. Comparing base (608a446) to head (f8b18aa).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #563   +/-   ##
=======================================
  Coverage   91.36%   91.37%           
=======================================
  Files          21       21           
  Lines        2073     2075    +2     
=======================================
+ Hits         1894     1896    +2     
  Misses        179      179           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ricardoV94 ricardoV94 mentioned this pull request Mar 1, 2024
14 tasks
Copy link
Collaborator

@ColtAllen ColtAllen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a simple fix and seems like a prerequisite to #564 which is a big one, so let's get this one merged.

@ricardoV94 ricardoV94 merged commit 9dda070 into pymc-labs:main Mar 1, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CLV model builder
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CLV models don't have working repr without model fit .build_model() Inconsistencies
2 participants