Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add notebook section for out of sample predictions #504

Merged
merged 1 commit into from
Jan 28, 2024

Conversation

wd60622
Copy link
Contributor

@wd60622 wd60622 commented Jan 28, 2024

Description

Related Issue

Checklist

Modules affected

  • MMM
  • CLV

Type of change

  • New feature / enhancement
  • Bug fix
  • Documentation
  • Maintenance
  • Other (please specify):

📚 Documentation preview 📚: https://pymc-marketing--504.org.readthedocs.build/en/504/

@wd60622 wd60622 added the docs Improvements or additions to documentation label Jan 28, 2024
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@wd60622
Copy link
Contributor Author

wd60622 commented Jan 28, 2024

Hey @juanitorduz
Sorry for a late PR. Take a look. I added to the end of the mmm notebook

Copy link
Collaborator

@juanitorduz juanitorduz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing !!! 🚀

@juanitorduz
Copy link
Collaborator

Hey @juanitorduz Sorry for a late PR. Take a look. I added to the end of the mmm notebook

No need to apologize 😉 ! This is exactly what we need to push this new feature out!

Copy link

codecov bot commented Jan 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2f2d814) 91.24% compared to head (8361956) 91.24%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #504   +/-   ##
=======================================
  Coverage   91.24%   91.24%           
=======================================
  Files          21       21           
  Lines        2044     2044           
=======================================
  Hits         1865     1865           
  Misses        179      179           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@juanitorduz juanitorduz merged commit 964957f into pymc-labs:main Jan 28, 2024
14 checks passed
@wd60622 wd60622 deleted the out-of-sample-docs branch April 8, 2024 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation MMM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document MMM out of sample prediction
2 participants