Add Weibull CDF and PDF Adstock Transformations #499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricardoV94
reviewed
Jan 26, 2024
pymc_marketing/mmm/transformers.py
Outdated
| k=1, | ||
| l_max: int = 12, | ||
| axis: int = 0, | ||
| type: WeibullType = WeibullType.PDF, |
There was a problem hiding this comment.
I would use string or a boolean variable so users don't have to import an object to be able to parametrize the function
There was a problem hiding this comment.
We have a similar interface for batched_convolution too. Maybe make it type: WeibullType | str = WeibullType.PDF?
There was a problem hiding this comment.
It will only every be pdf or not pdf (cdf), right? Think the boolean simplifies it heavily
wd60622
reviewed
Jan 26, 2024
ricardoV94
approved these changes
Jan 27, 2024
wd60622
approved these changes
Jan 27, 2024
pymc_marketing/mmm/transformers.py
Outdated
| Shape parameter of the Weibull distribution. Must be positive. | ||
| l_max : int, by default 12 | ||
| Maximum duration of carryover effect. | ||
| type : WeibullType, by default WeibullType.PDF |
There was a problem hiding this comment.
Maybe good to add string to match with the type hint
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #499 +/- ##
==========================================
+ Coverage 91.24% 91.32% +0.08%
==========================================
Files 21 21
Lines 2044 2063 +19
==========================================
+ Hits 1865 1884 +19
Misses 179 179 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request add the
weibull_adstock function, providing support for both Weibull CDF and PDF adstock transformations.Related Issue
Checklist
Modules affected
Type of change
📚 Documentation preview 📚: https://pymc-marketing--499.org.readthedocs.build/en/499/