Draft [Creating a Hierarchical MMM - Model]

[cetagostini]

Description

Hey everyone, I wanted to remind you about our discussion from a few meetings ago. We talked about the possibility of adding a model that can generate hierarchies. Essentially, the idea is to create a module that will enable us to add hierarchies easily.

I've been working on a draft notebook that demonstrates the implementation of this idea. It's based on the base module, but I've made a few adjustments to make it work better. I'd like to get your feedback on it when you have a chance.

Related Issue

• Closes issue: #
• Related issue (not closed by this PR): Please can you add Hierarchical model for MMM  #334

Checklist

• Checked that the pre-commit linting/style checks pass
• Included tests that prove the fix is effective or that the new feature works
• Added necessary documentation (docstrings and/or example notebooks)
• If you are a pro: each commit corresponds to a relevant logical change

Modules affected

• MMM
• CLV

Type of change

• New feature / enhancement
• Bug fix
• Documentation
• Maintenance
• Other (please specify):

---

📚 Documentation preview 📚: https://pymc-marketing--460.org.readthedocs.build/en/460/

[cetagostini]

Notebook in progress . . .

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.82%. Comparing base (890c469) to head (7616f0f).
Report is 253 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #460   +/-   ##
=======================================
  Coverage   90.82%   90.82%           
=======================================
  Files          21       21           
  Lines        1972     1972           
=======================================
  Hits         1791     1791           
  Misses        181      181           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[review-notebook-app]

Check out this pull request on 

See visual diffs & provide feedback on Jupyter Notebooks.

---

Powered by ReviewNB

[cetagostini]

Updated plot | Channel response curve by Hierarchy

[wd60622]

Updated plot | Channel response curve by Hierarchy

That's epic. Can you try for channel to be same color and hierarchy to be, say, linestyle? Think it'd be easier to read

[review-notebook-app]

View / edit / reply to this conversation on ReviewNB

wd60622 commented on 2023-12-10T09:06:24Z
----------------------------------------------------------------

Is it possible to make use of the pd.DataFrame.to_xarray method?

It might look like this

pd.DataFrame(...).set_index(["date", "control", "hierarchy"]).to_xarray()

[review-notebook-app]

View / edit / reply to this conversation on ReviewNB

wd60622 commented on 2023-12-10T09:06:25Z
----------------------------------------------------------------

It'd be interesting to plot the "average" curve then the two hierarchy levels around that. To show that the curves are being pulled somewhere

[twiecki]

What's the status of this? Any blockers to moving this forward?

[cetagostini]

I'll open a new PR with this!