Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mismatched customer count in CLV Quickstart guide #419

Merged
merged 1 commit into from
Nov 5, 2023

Conversation

takechanman1228
Copy link
Contributor

@takechanman1228 takechanman1228 commented Nov 5, 2023

Overview

This Pull Request corrects a discrepancy in the CLV quickstart guide documentation. The guide currently states to look at the "five more promising customers," while the associated code snippet is actually designed to display the top four customers.

Details

The specific line in the documentation that has been updated is:

  • Before: Let's look at the five more promising customers.
  • After: Let's look at the four more promising customers.

The corresponding code that illustrates this operation is:

sdata.sort_values(by="expected_purchases").tail(4)

As the code correctly fetches the top four customers, no changes to the code were required—only the textual description needed to be updated to reflect the actual behavior of the code.

Additional Information

Please find attached a screenshot which demonstrates the code's output prior to the documentation correction.
image


📚 Documentation preview 📚: https://pymc-marketing--419.org.readthedocs.build/en/419/

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@twiecki
Copy link
Contributor

twiecki commented Nov 5, 2023

Thanks @takechanman1228!

@twiecki twiecki merged commit fb938bf into pymc-labs:main Nov 5, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants