Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MMM: fix quickstart instructions not working #403

Merged
merged 1 commit into from
Oct 22, 2023
Merged

MMM: fix quickstart instructions not working #403

merged 1 commit into from
Oct 22, 2023

Conversation

MarkusSagen
Copy link
Contributor

@MarkusSagen MarkusSagen commented Oct 21, 2023

Updated the MMM quickstart instructions and data for the MMM quickstart on the pymc-marketing start page

Fixes #384 Quickstart instructions give errors


📚 Documentation preview 📚: https://pymc-marketing--403.org.readthedocs.build/en/403/

@twiecki
Copy link
Contributor

twiecki commented Oct 22, 2023

Thanks @MarkusSagen, this is a great contribution!

@MarkusSagen
Copy link
Contributor Author

Happy to give back to the community and all the great work the team is doing!

Are there any other issues that I could help tackle?

@codecov
Copy link

codecov bot commented Oct 22, 2023

Codecov Report

Merging #403 (dc190f7) into main (32098cc) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #403   +/-   ##
=======================================
  Coverage   88.71%   88.71%           
=======================================
  Files          21       21           
  Lines        1869     1869           
=======================================
  Hits         1658     1658           
  Misses        211      211           

@twiecki twiecki merged commit 29a69f6 into pymc-labs:main Oct 22, 2023
13 checks passed
@twiecki
Copy link
Contributor

twiecki commented Oct 22, 2023

Yes, much appreciated. This could be a good place to start: good first issue Good for newcomers

@MarkusSagen
Copy link
Contributor Author

Thanks! Will take a look

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Quickstart instructions give errors
2 participants