Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't run prior and posterior predictive when calling fit #365

Merged
merged 9 commits into from
Sep 1, 2023

Conversation

michaelraczycki
Copy link
Contributor

@michaelraczycki michaelraczycki commented Aug 19, 2023

This PR contains the following changes:

sample_model() - removed from the fit() call, each sampling should be called directly and independently by it's corresponding function. Attributes handling moved to fit()
mypy fixes
docstrings updates and changes


📚 Documentation preview 📚: https://pymc-marketing--365.org.readthedocs.build/en/365/

@codecov
Copy link

codecov bot commented Aug 20, 2023

Codecov Report

Merging #365 (fcd30c6) into main (4c9f4ca) will increase coverage by 0.88%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #365      +/-   ##
==========================================
+ Coverage   93.62%   94.51%   +0.88%     
==========================================
  Files          20       20              
  Lines        1664     1659       -5     
==========================================
+ Hits         1558     1568      +10     
+ Misses        106       91      -15     
Files Changed Coverage Δ
pymc_marketing/clv/models/basic.py 97.87% <100.00%> (ø)
pymc_marketing/mmm/base.py 97.50% <100.00%> (ø)
pymc_marketing/mmm/delayed_saturated_mmm.py 100.00% <100.00%> (ø)
pymc_marketing/model_builder.py 83.06% <100.00%> (+7.52%) ⬆️

@michaelraczycki
Copy link
Contributor Author

@ricardoV94 , @juanitorduz please let me know what you think about it, I think it might be first step on improving the time length our tests take to finish

@michaelraczycki
Copy link
Contributor Author

merging this should close #364

@juanitorduz
Copy link
Collaborator

juanitorduz commented Aug 21, 2023

@ricardoV94 , @juanitorduz please let me know what you think about it, I think it might be first step on improving the time length our tests take to finish

Thanks! This was definitely needed! I still wanna avoid sampling for the plot tests :) I will do it on another PR

pymc_marketing/model_builder.py Outdated Show resolved Hide resolved
@ricardoV94 ricardoV94 changed the title fit adjustments Don't run prior and posterior predictive when calling fit Sep 1, 2023
@michaelraczycki michaelraczycki merged commit 7119b01 into pymc-labs:main Sep 1, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants