-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't run prior and posterior predictive when calling fit
#365
Don't run prior and posterior predictive when calling fit
#365
Conversation
…predictive sampling optional
Codecov Report
@@ Coverage Diff @@
## main #365 +/- ##
==========================================
+ Coverage 93.62% 94.51% +0.88%
==========================================
Files 20 20
Lines 1664 1659 -5
==========================================
+ Hits 1558 1568 +10
+ Misses 106 91 -15
|
@ricardoV94 , @juanitorduz please let me know what you think about it, I think it might be first step on improving the time length our tests take to finish |
merging this should close #364 |
Thanks! This was definitely needed! I still wanna avoid sampling for the plot tests :) I will do it on another PR |
fit
This PR contains the following changes:
sample_model() - removed from the fit() call, each sampling should be called directly and independently by it's corresponding function. Attributes handling moved to fit()
mypy fixes
docstrings updates and changes
📚 Documentation preview 📚: https://pymc-marketing--365.org.readthedocs.build/en/365/