Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional ax argument to CLV plot utilities #344

Merged
merged 5 commits into from
Aug 10, 2023

Conversation

wd60622
Copy link
Contributor

@wd60622 wd60622 commented Aug 5, 2023

Closes #342

@codecov
Copy link

codecov bot commented Aug 5, 2023

Codecov Report

Merging #344 (071b070) into main (12b56e2) will increase coverage by 0.13%.
The diff coverage is 14.28%.

@@            Coverage Diff             @@
##             main     #344      +/-   ##
==========================================
+ Coverage   95.85%   95.98%   +0.13%     
==========================================
  Files          19       19              
  Lines        1447     1446       -1     
==========================================
+ Hits         1387     1388       +1     
+ Misses         60       58       -2     
Files Changed Coverage Δ
pymc_marketing/clv/plotting.py 16.27% <14.28%> (+2.64%) ⬆️

@ricardoV94 ricardoV94 added enhancement New feature or request CLV labels Aug 6, 2023
@ricardoV94 ricardoV94 changed the title add optional ax argument Add optional ax argument to CLV plot utilities Aug 6, 2023
Copy link
Collaborator

@juanitorduz juanitorduz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@ricardoV94 ricardoV94 merged commit 601fca8 into pymc-labs:main Aug 10, 2023
10 of 11 checks passed
@ricardoV94
Copy link
Contributor

Thanks @wd60622

@wd60622 wd60622 deleted the add-axes-argument branch August 10, 2023 10:31
@ricardoV94 ricardoV94 added maintenance and removed enhancement New feature or request labels Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

plt.Axes argument in CLV plots
3 participants