MMM load updates #317
Merged
MMM load updates #317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juanitorduz
reviewed
Jul 6, 2023
|
the failure of test CI is expected, as a release on pymc-experimental is needed. Please add your thoughts regardless, so we can proceed when release is done |
Codecov Report
@@ Coverage Diff @@
## main #317 +/- ##
==========================================
+ Coverage 95.16% 95.45% +0.29%
==========================================
Files 19 19
Lines 1406 1430 +24
==========================================
+ Hits 1338 1365 +27
+ Misses 68 65 -3
|
|
@ricardoV94 can we merge this? |
ricardoV94
approved these changes
Jul 12, 2023
pymc_marketing/mmm/base.py
Outdated
| @@ -30,6 +30,8 @@ | |||
|
|
|||
| class BaseMMM(ModelBuilder): | |||
| model: pm.Model | |||
| _model_type = "baseMMM" | |||
There was a problem hiding this comment.
Suggested change
| _model_type = "baseMMM" | |
| _model_type = "BaseMMM" |
michaelraczycki
added a commit
to michaelraczycki/pymc-marketing
that referenced
this pull request
Jul 26, 2023
* fixed dims format, added save_load test to delayed_saturated_mmm * removing temp file after test_save_load in DelayedSaturatedMMM tests * unifying save tests, adding model.id checks into load * pymc-experimental version bump * removing property @posterior_predictive from basic.py * extending tests to cover id preservation with load * _model_type update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed dims format, added save_load test to delayed_saturated_mmm. Now MMM classes can properly use save/load functionality
📚 Documentation preview 📚: https://pymc-marketing--317.org.readthedocs.build/en/317/