-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MMM load updates #317
MMM load updates #317
Conversation
the failure of test CI is expected, as a release on pymc-experimental is needed. Please add your thoughts regardless, so we can proceed when release is done |
Codecov Report
@@ Coverage Diff @@
## main #317 +/- ##
==========================================
+ Coverage 95.16% 95.45% +0.29%
==========================================
Files 19 19
Lines 1406 1430 +24
==========================================
+ Hits 1338 1365 +27
+ Misses 68 65 -3
|
@ricardoV94 can we merge this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just a nitpick with the name
pymc_marketing/mmm/base.py
Outdated
@@ -30,6 +30,8 @@ | |||
|
|||
class BaseMMM(ModelBuilder): | |||
model: pm.Model | |||
_model_type = "baseMMM" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
_model_type = "baseMMM" | |
_model_type = "BaseMMM" |
* fixed dims format, added save_load test to delayed_saturated_mmm * removing temp file after test_save_load in DelayedSaturatedMMM tests * unifying save tests, adding model.id checks into load * pymc-experimental version bump * removing property @posterior_predictive from basic.py * extending tests to cover id preservation with load * _model_type update
fixed dims format, added save_load test to delayed_saturated_mmm. Now MMM classes can properly use save/load functionality
📚 Documentation preview 📚: https://pymc-marketing--317.org.readthedocs.build/en/317/