-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#1020 Correction of doctring for plot.py for sample_kwargs
#1060
#1020 Correction of doctring for plot.py for sample_kwargs
#1060
Conversation
sample_kwargs
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1060 +/- ##
===========================================
- Coverage 95.85% 37.51% -58.34%
===========================================
Files 39 39
Lines 3934 3934
===========================================
- Hits 3771 1476 -2295
- Misses 163 2458 +2295
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
pymc_marketing/mmm/plot.py
Outdated
@@ -570,7 +570,7 @@ def plot_curve( | |||
subplot_kwargs : dict, optional | |||
Addtional kwargs to while creating the fig and axes | |||
sample_kwargs : dict, optional | |||
Kwargs for the :func:`plot_curve` function | |||
Kwargs for the :func:`plot_sample` function |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think is plot_samples
right? (s at the end)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay! just done this.
Thanks @Ishaanjolly |
…pymc-labs#1060) * feat: test.txt added for commit check * feat: replaced plot_curve with plot_samples within ./mmm/plot.py * fix: plot_samples instead of plot_sample
Description
Sample Kwargs now has plot_samples instead of plot_curve -Related Issue
plot_curve
references wrong function insample_kwargs
description #1020plot_curve
references wrong function insample_kwargs
description #1020Checklist
Modules affected
Type of change
📚 Documentation preview 📚: https://pymc-marketing--1060.org.readthedocs.build/en/1060/