Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

comment save notebook in mmm example #1053

Merged
merged 1 commit into from
Sep 20, 2024
Merged

Conversation

juanitorduz
Copy link
Collaborator

@juanitorduz juanitorduz commented Sep 19, 2024

This saving cell is problematic in the CI. We can done this in the past but the change was undone XD


📚 Documentation preview 📚: https://pymc-marketing--1053.org.readthedocs.build/en/1053/

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@juanitorduz juanitorduz added docs Improvements or additions to documentation MMM labels Sep 19, 2024
@wd60622
Copy link
Contributor

wd60622 commented Sep 19, 2024

Maybe there is a magic cell or tag that can be used. I will check the papermill docs

Found this:
nteract/papermill#429

This might be a good alternative
nteract/papermill#429 (comment)

Copy link
Contributor

@wd60622 wd60622 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments arent blocker. Just some thoughts

@juanitorduz juanitorduz merged commit e60aaca into main Sep 20, 2024
8 checks passed
@juanitorduz juanitorduz deleted the comment_save_model_mmm_nb branch September 20, 2024 05:47
jsnyde0 pushed a commit to jsnyde0/pymc-marketing that referenced this pull request Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation MMM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants