use maxent from preliz instead of find_constrained_prior #1011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1011 +/- ##
==========================================
- Coverage 95.58% 95.56% -0.02%
==========================================
Files 38 38
Lines 3690 3696 +6
==========================================
+ Hits 3527 3532 +5
- Misses 163 164 +1 ☔ View full report in Codecov by Sentry. |
juanitorduz
approved these changes
Sep 9, 2024
|
View / edit / reply to this conversation on ReviewNB cetagostini commented on 2024-09-09T21:10:39Z LOVE THIS!!! Amazing feature! |
twiecki
pushed a commit
that referenced
this pull request
Sep 10, 2024
* use maxent from preliz instead of find_contrained_prior * update tests --------- Co-authored-by: Juan Orduz <[email protected]>
twiecki
pushed a commit
that referenced
this pull request
Sep 10, 2024
* use maxent from preliz instead of find_contrained_prior * update tests --------- Co-authored-by: Juan Orduz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PyMC's
find_constrained_priorhas been deprecated. This PR changesconstrainfunction to use PreliZ's maxent.📚 Documentation preview 📚: https://pymc-marketing--1011.org.readthedocs.build/en/1011/