-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use maxent from preliz instead of find_constrained_prior #1011
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1011 +/- ##
==========================================
- Coverage 95.58% 95.56% -0.02%
==========================================
Files 38 38
Lines 3690 3696 +6
==========================================
+ Hits 3527 3532 +5
- Misses 163 164 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @aloctavodia !
View / edit / reply to this conversation on ReviewNB cetagostini commented on 2024-09-09T21:10:39Z LOVE THIS!!! Amazing feature! |
* use maxent from preliz instead of find_contrained_prior * update tests --------- Co-authored-by: Juan Orduz <[email protected]>
* use maxent from preliz instead of find_contrained_prior * update tests --------- Co-authored-by: Juan Orduz <[email protected]>
PyMC's
find_constrained_prior
has been deprecated. This PR changesconstrain
function to use PreliZ's maxent.📚 Documentation preview 📚: https://pymc-marketing--1011.org.readthedocs.build/en/1011/