Skip to content

Commit

Permalink
Correcting position values
Browse files Browse the repository at this point in the history
  • Loading branch information
cetagostini committed Sep 30, 2023
1 parent 7562714 commit aeb7faf
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions pymc_marketing/mmm/base.py
Original file line number Diff line number Diff line change
Expand Up @@ -486,7 +486,7 @@ def compute_channel_contribution_original_scale(self) -> DataArray:
)

def _estimate_budget_contribution_fit(
self, channel: str, budget: float, method: str
self, channel: str, budget: float, method: str = "sigmoid"
) -> Tuple:
"""
Estimate the lower and upper bounds of the contribution fit for a given channel and budget.
Expand Down Expand Up @@ -615,7 +615,7 @@ def _plot_scenario(
)

def plot_budget_scenearios(
self, *, base_data: Dict, method: str, **kwargs
self, *, base_data: Dict, method: str = "sigmoid", **kwargs
) -> plt.Figure:
"""
Experimental: Plots the budget and contribution bars side by side for multiple scenarios.
Expand Down Expand Up @@ -657,7 +657,7 @@ def plot_budget_scenearios(
for channel, budget in scenario["budget"].items():
if channel != "total":
y_fit_lower, y_fit_upper = self._estimate_budget_contribution_fit(

Check warning on line 659 in pymc_marketing/mmm/base.py

View check run for this annotation

Codecov / codecov/patch

pymc_marketing/mmm/base.py#L654-L659

Added lines #L654 - L659 were not covered by tests
method, channel, budget
method=method, channel=channel, budget=budget
)
upper_bound[channel] = y_fit_upper
lower_bound[channel] = y_fit_lower
Expand Down

0 comments on commit aeb7faf

Please sign in to comment.