Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated Distribution kwargs #7488

Merged

Conversation

thomasaarholt
Copy link
Contributor

@thomasaarholt thomasaarholt commented Sep 3, 2024

Description

Removing these to reduce cognitive load for an eventual migration to a function-based distribution.

These were deprecated in #4500 and #5109, in 2021, as part of pymc 4 being released. We're on 5.x so these should be safe to remove now.

I found about six more deprecated instances of code that were deprecated before the 5.0 release. I don't want to overload maintainers with more work, so will only make a PR with those if it is desired.

Related Issue

Checklist

Type of change

  • New feature / enhancement
  • Bug fix
  • Documentation
  • Maintenance
  • Other (please specify):

📚 Documentation preview 📚: https://pymc--7488.org.readthedocs.build/en/7488/

Removing these to reduce cognitive load for an
eventual migration to a function-based
distribution.

These were deprecated in pymc-devs#5109, in 2021, as part
of pymc 4 being released. We're on 5.x so these
should be safe.
@ricardoV94 ricardoV94 added maintenance major Include in major changes release notes section labels Sep 3, 2024
@ricardoV94
Copy link
Member

One test is failing

@thomasaarholt
Copy link
Contributor Author

Thanks, missed that one, will add this afternoon.

I keep the test, since it seems to cover behaviour not tested elsewhere.
Copy link

codecov bot commented Sep 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.16%. Comparing base (253513b) to head (e599d0f).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #7488      +/-   ##
==========================================
+ Coverage   91.04%   92.16%   +1.12%     
==========================================
  Files         103      103              
  Lines       17221    17200      -21     
==========================================
+ Hits        15679    15853     +174     
+ Misses       1542     1347     -195     
Files with missing lines Coverage Δ
pymc/distributions/distribution.py 91.89% <ø> (+0.33%) ⬆️

... and 4 files with indirect coverage changes

@ricardoV94 ricardoV94 merged commit d596afb into pymc-devs:main Sep 3, 2024
22 checks passed
@ricardoV94
Copy link
Member

Thanks @thomasaarholt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance major Include in major changes release notes section
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants