Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reject logp derivation of binary operations with broadcasted measurable input #6893

Merged

Conversation

shreyas3156
Copy link
Contributor

@shreyas3156 shreyas3156 commented Sep 4, 2023

What is this PR about?
Resolves #6880. This PR makes sure that no duplication is done and that the variables are conditionally independent.

Checklist

Bugfixes

  • This PR makes sure that the broadcastability of measurable inputs in binary graphs is disallowed.

📚 Documentation preview 📚: https://pymc--6893.org.readthedocs.build/en/6893/

@codecov
Copy link

codecov bot commented Sep 4, 2023

Codecov Report

Merging #6893 (92b98f5) into main (dfb05b6) will increase coverage by 0.10%.
Report is 2 commits behind head on main.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6893      +/-   ##
==========================================
+ Coverage   92.05%   92.16%   +0.10%     
==========================================
  Files          96      100       +4     
  Lines       16446    16852     +406     
==========================================
+ Hits        15140    15531     +391     
- Misses       1306     1321      +15     
Files Changed Coverage Δ
pymc/logprob/binary.py 96.47% <100.00%> (+0.08%) ⬆️

... and 10 files with indirect coverage changes

@ricardoV94 ricardoV94 changed the title Deny broadcasting of measurable input in logp derivation of binary graphs Reject logp derivation of binary operations with broadcasted measurable input Sep 5, 2023
@ricardoV94 ricardoV94 merged commit e6e0fed into pymc-devs:main Sep 5, 2023
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Logprob derivation of binary graphs allow broadcast of measurable input
2 participants