Logprob derivation of Max for Discrete IID distributions #6790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #6790 +/- ##
==========================================
- Coverage 92.07% 82.41% -9.66%
==========================================
Files 100 100
Lines 16875 16886 +11
==========================================
- Hits 15538 13917 -1621
- Misses 1337 2969 +1632
|
ricardoV94
changed the title
ricardoV94
previously approved these changes
Jul 17, 2023
Dhruvanshu-Joshi
force-pushed
the
dev-order_discrete
branch
from
14cd1c8
to
57d0ac2
Compare
|
@ricardoV94 @larryshamalama I have updated this branch as per latest modifications and also modified it to support Discrete distributions. Now we need tests to support discrete distribution! 🙂 |
Dhruvanshu-Joshi
force-pushed
the
dev-order_discrete
branch
from
57d0ac2
to
c9d4697
Compare
ricardoV94
reviewed
Aug 14, 2023
ricardoV94
reviewed
Aug 14, 2023
ricardoV94
requested changes
Aug 14, 2023
Dhruvanshu-Joshi
force-pushed
the
dev-order_discrete
branch
from
c9d4697
to
be1ee9f
Compare
ricardoV94
reviewed
Sep 4, 2023
ricardoV94
reviewed
Sep 4, 2023
Dhruvanshu-Joshi
force-pushed
the
dev-order_discrete
branch
from
be1ee9f
to
f505cef
Compare
Dhruvanshu-Joshi
force-pushed
the
dev-order_discrete
branch
from
f505cef
to
3f2f160
Compare
Dhruvanshu-Joshi
force-pushed
the
dev-order_discrete
branch
from
27a4348
to
fd969bb
Compare
|
Hey @ricardoV94 @larryshamalama . I have added the changes and this branch seems good to merge. |
ricardoV94
changed the title
ricardoV94
reviewed
Oct 17, 2023
ricardoV94
approved these changes
Oct 17, 2023
Dhruvanshu-Joshi
force-pushed
the
dev-order_discrete
branch
from
d3c45f5
to
894ff27
Compare
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR about?
This PR is the extension of PR #6769 and aims to provide a solution for implementing the Max operation for discrete distributions from order statistics to solve the issue #6350 and issue #6773.
Checklist
Major / Breaking Changes
New features
Bugfixes
Documentation
Maintenance
📚 Documentation preview 📚: https://pymc--6790.org.readthedocs.build/en/6790/