Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add icdf function for Cauchy and Logistic distributions #6747

Merged
merged 7 commits into from
Jun 16, 2023

Conversation

amyoshino
Copy link
Member

@amyoshino amyoshino commented Jun 1, 2023

What is this PR about?
Adds ICDF functions to

  • Cauchy Distribution
  • Logistic Distribution

References:
https://en.wikipedia.org/wiki/Logistic_distribution
https://en.wikipedia.org/wiki/Cauchy_distribution

Issue #6612

Checklist

Major / Breaking Changes

  • ...

New features

  • Cauchy.icdf function.
  • Logistic.icdf function.

Bugfixes

  • ...

Documentation

  • ...

Maintenance

  • ...

📚 Documentation preview 📚: https://pymc--6747.org.readthedocs.build/en/6747/

@codecov
Copy link

codecov bot commented Jun 1, 2023

Codecov Report

Merging #6747 (53418bd) into main (154f5b0) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #6747   +/-   ##
=======================================
  Coverage   91.89%   91.90%           
=======================================
  Files          95       95           
  Lines       16147    16155    +8     
=======================================
+ Hits        14839    14847    +8     
  Misses       1308     1308           
Impacted Files Coverage Δ
pymc/distributions/continuous.py 97.75% <100.00%> (+0.01%) ⬆️

@amyoshino

This comment was marked as outdated.

@amyoshino

This comment was marked as outdated.

@amyoshino amyoshino changed the title adding icdf function for lognormal adding icdf function for LogNormal, Cauchy and Logistic with tests Jun 1, 2023
@amyoshino
Copy link
Member Author

amyoshino commented Jun 2, 2023

Ok, I decided to transform this into a PR for the Cauchy and Logistic distributions only. I will work with LogNormal in a separate PR, posting my findings about the precision issue I'm having with the test.

Apologies for this turnaround, please let me know if anything for Cauchy and Logistic is missing here.

Thanks,

@amyoshino amyoshino changed the title adding icdf function for LogNormal, Cauchy and Logistic with tests adding icdf function for Cauchy and Logistic with tests Jun 2, 2023
@amyoshino
Copy link
Member Author

I believe this PR is good to go! Let me know if you need me to work on anything with these two functions and tests.

Copy link
Member

@ricardoV94 ricardoV94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@ricardoV94 ricardoV94 merged commit 77f24d7 into pymc-devs:main Jun 16, 2023
@ricardoV94 ricardoV94 changed the title adding icdf function for Cauchy and Logistic with tests Add icdf function for Cauchy and Logistic with tests Jun 16, 2023
@ricardoV94 ricardoV94 changed the title Add icdf function for Cauchy and Logistic with tests Add icdf function for Cauchy and Logistic distributions Jun 16, 2023
@amyoshino amyoshino deleted the icdf_lognormal branch June 16, 2023 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants