GP Mauna Loa with PyMC3 best practices

[danhphan]

This PR update the GP Mauna Loa notebook with PyMC3 best practices. This is related to issue #73

General changes:

• Run with pymc v3 on the latest dataset,
• Remove dead links, unrelated dependencies
• Following Jupyter Style, update meta-data.

Please let me know if it needs to change anything. Thanks

[review-notebook-app]

Check out this pull request on 

See visual diffs & provide feedback on Jupyter Notebooks.

---

Powered by ReviewNB

[review-notebook-app]

View / edit / reply to this conversation on ReviewNB

OriolAbril commented on 2022-04-24T10:57:46Z
----------------------------------------------------------------

I would use gaussian process as tag instead of GP. I also have no memory of working on this notebook, so I am not sure I should be an author, did you add me from seeing me on a PR or the git history? If so could you share a link to the changes?

danhphan commented on 2022-04-25T09:07:48Z
----------------------------------------------------------------

Hi agree, I will use Gaussian Process in both the title and tag instead of GP, it should be clearer for readers.

I assume the authors from the Github PRs history at this link , from that you can see the details of the previous commits. So what contents should we put in this tag?

Also, please suggest what should I put in this Authorship and attribution section. Should it somethings like this?

* Authored by Chris Fonnesbeck in ...
* Updated by Oriol Abril-Pla in ...
* Updated by Danh Phan in ...

Thanks.

OriolAbril commented on 2022-04-29T19:50:19Z
----------------------------------------------------------------

It looks like it was authored by Bill. Most notebooks were added when all notebooks were part of the main pymc repo. The "first" commit you see is Chris starting the pymc-examples repo. This is the history of the file before that. In this case I think something like:

* Authored by Bill Engels in 2017
* Updated by Chris Fonnesbeck in 2020
* Updated by Danh Phan in 2022

No need to focus too much on tracking the history down. I should not appear there though as I didn't do any changes to the notebook. I added the myst views and syncing removed trailing whitespaces and things like that so I appear on the history

danhphan commented on 2022-05-01T02:30:28Z
----------------------------------------------------------------

Hi, I have updated the notebook.

As I only do minor changes, I use the Re-executed by Danh Phan in 2022 which will more suitable.

Thank you.

[review-notebook-app]

View / edit / reply to this conversation on ReviewNB

OriolAbril commented on 2022-04-24T10:57:46Z
----------------------------------------------------------------

after this cell you should add:

• References cell with bibliography (you'll also need to add the R&W book to the bibtex file). There is no need to cite it every time (or at all, you can also include titles in the bibliography that have not been cited in the page). Everything should be explained in https://docs.pymc.io/en/latest/contributing/jupyter_style.html#references
• Authors section: https://docs.pymc.io/en/latest/contributing/jupyter_style.html#authorship-and-attribution

danhphan commented on 2022-04-25T09:07:56Z
----------------------------------------------------------------

Yes, I will update this.

[review-notebook-app]

View / edit / reply to this conversation on ReviewNB

OriolAbril commented on 2022-04-24T10:57:47Z
----------------------------------------------------------------

You need to add libraries to the watermark that are not imported explicitly but are important to reproduce the run. See https://docs.pymc.io/en/latest/contributing/jupyter_style.html#watermark

And you should also add the page footer thing: https://docs.pymc.io/en/latest/contributing/jupyter_style.html#epilogue

danhphan commented on 2022-04-25T09:08:03Z
----------------------------------------------------------------

Yes.

[danhphan]

Hi agree, I will use Gaussian Process in both the title and tag instead of GP, it should be clearer for readers.

I assume the authors from the Github PRs history at this link , from that you can see the details of the previous commits. So what contents should we put in this tag?

Also, please suggest what should I put in this Authorship and attribution section. Should it somethings like this?

* Authored by Chris Fonnesbeck in ...
* Updated by Oriol Abril-Pla in ...
* Updated by Danh Phan in ...

Thanks.

---

View entire conversation on ReviewNB

[danhphan]

Yes, I will update this.

---

View entire conversation on ReviewNB

[danhphan]

Yes.

---

View entire conversation on ReviewNB

[OriolAbril]

It looks like it was authored by Bill. Most notebooks were added when all notebooks were part of the main pymc repo. The "first" commit you see is Chris starting the pymc-examples repo. This is the history of the file before that. In this case I think something like:

* Authored by Bill Engels in 2017
* Updated by Chris Fonnesbeck in 2020
* Updated by Danh Phan in 2022

No need to focus too much on tracking the history down. I should not appear there though as I didn't do any changes to the notebook. I added the myst views and syncing removed trailing whitespaces and things like that so I appear on the history

---

View entire conversation on ReviewNB

[danhphan]

Hi, I have updated the notebook.

As I only do minor changes, I use the Re-executed by Danh Phan in 2022 which will more suitable.

Thank you.

---

View entire conversation on ReviewNB

[danhphan]

Thanks @OriolAbril, I've just updated the suggestions. Hopefully it will be alright now :)