Add a Null backend #112
Merged
Add a Null backend #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alcrene
referenced
this pull request
in alcrene/mcbackend
Jun 9, 2024
A null storage for draws from a chain: gobbles up draws without storing them Possible use cases include - Online computations: Draws are used and discarded immediately, allowing for much larger sample spaces. - Profiling: To use as a baseline, to measure compute time & memory before allocating memory for draws. Comparing with another backend would then show how much overhead it adds.
Tests were copied from test_backend_numpy and the parts checking the `_samples` array removed.
Fixed issue:
- Reset default preallocation to 1_000, like with NumPyBackend:
it is still used for the stats array, so it makes sense to use
a reasonable default.
- Preallocate = 0 no longer switches the allocation to object arrays,
in contrast to NumPyBackend
- IMO this is a bug in NumPyBackend: `grow_append` cannot know if
``preallocate = 0`` was used; it only looks at the `rigid` value
to determine how to append.
- Without this change, `grow_append` will always fail when we use
`preallocate = 0` with multivariate statistics.
michaelosthege
force-pushed
the
feature/NullBackend
branch
from
54aad19
to
f2666dd
Compare
michaelosthege
approved these changes
Jun 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
NullBackendgobbles up draws without storing themPossible use cases include
Comparing with another backend would then show how much overhead it adds.