-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests #9981
base: main
Are you sure you want to change the base?
Add tests #9981
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, do you mind cleaning up the commit tree, look like something we would want to rebase and not squash. (Also you can add the tests / 🧪 in the MR template if you want :) )
I can fix up the commits, but it will require rerunning all the tests to update their output. Could you merge #9982 first so I can run Pytest? |
Type of Changes
Description
Add tests for open issues #9668, #9815, #8893, #9941, #9642, and #9689. Some are false negatives and some are false positives.