Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump astroid to 3.3.3 #9939

Merged
merged 1 commit into from
Sep 20, 2024
Merged

Bump astroid to 3.3.3 #9939

merged 1 commit into from
Sep 20, 2024

Conversation

jacobtylerwalls
Copy link
Member

No description provided.

@jacobtylerwalls jacobtylerwalls added Maintenance Discussion or action around maintaining pylint or the dev workflow Skip news 🔇 This change does not require a changelog entry labels Sep 20, 2024
@jacobtylerwalls jacobtylerwalls added this to the 3.3.0 milestone Sep 20, 2024
Copy link

codecov bot commented Sep 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.80%. Comparing base (7d60c27) to head (2cbaed1).
Report is 6 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #9939   +/-   ##
=======================================
  Coverage   95.80%   95.80%           
=======================================
  Files         174      174           
  Lines       18933    18933           
=======================================
  Hits        18139    18139           
  Misses        794      794           

Copy link
Contributor

🤖 Effect of this PR on checked open source code: 🤖

Effect on home-assistant:
The following messages are no longer emitted:

  1. no-member:
    Instance of 'BaseZhaFlow' has no 'async_add_executor_job' member
    https://github.com/home-assistant/core/blob/efdb1073a149e0fb8a506d96be032b5404a34215/homeassistant/components/zha/config_flow.py#L162
  2. no-member:
    Instance of 'BaseZhaFlow' has no 'async_add_executor_job' member
    https://github.com/home-assistant/core/blob/efdb1073a149e0fb8a506d96be032b5404a34215/homeassistant/components/zha/config_flow.py#L413
  3. no-member:
    Instance of 'ZhaConfigFlowHandler' has no 'config_entries' member
    https://github.com/home-assistant/core/blob/efdb1073a149e0fb8a506d96be032b5404a34215/homeassistant/components/zha/config_flow.py#L596
  4. no-member:
    Instance of 'ZhaConfigFlowHandler' has no 'config_entries' member
    https://github.com/home-assistant/core/blob/efdb1073a149e0fb8a506d96be032b5404a34215/homeassistant/components/zha/config_flow.py#L598
  5. no-member:
    Instance of 'ZhaOptionsFlowHandler' has no 'config_entries' member
    https://github.com/home-assistant/core/blob/efdb1073a149e0fb8a506d96be032b5404a34215/homeassistant/components/zha/config_flow.py#L698
  6. no-member:
    Instance of 'ZhaOptionsFlowHandler' has no 'async_add_executor_job' member
    https://github.com/home-assistant/core/blob/efdb1073a149e0fb8a506d96be032b5404a34215/homeassistant/components/zha/config_flow.py#L749
  7. no-member:
    Instance of 'ZhaOptionsFlowHandler' has no 'config_entries' member
    https://github.com/home-assistant/core/blob/efdb1073a149e0fb8a506d96be032b5404a34215/homeassistant/components/zha/config_flow.py#L754
  8. no-member:
    Instance of 'ZhaOptionsFlowHandler' has no 'config_entries' member
    https://github.com/home-assistant/core/blob/efdb1073a149e0fb8a506d96be032b5404a34215/homeassistant/components/zha/config_flow.py#L764
  9. no-member:
    Instance of 'ZhaOptionsFlowHandler' has no 'async_create_task' member
    https://github.com/home-assistant/core/blob/efdb1073a149e0fb8a506d96be032b5404a34215/homeassistant/components/zha/config_flow.py#L777
  10. no-member:
    Instance of 'ZhaOptionsFlowHandler' has no 'config_entries' member
    https://github.com/home-assistant/core/blob/efdb1073a149e0fb8a506d96be032b5404a34215/homeassistant/components/zha/config_flow.py#L778

Effect on music21:
The following messages are now emitted:

  1. useless-suppression:
    Useless suppression of 'attribute-defined-outside-init'
    https://github.com/cuthbertLab/music21/blob/e05fc53dfef7b2c9ac974c0cacb8b85e9c4d4605/music21/note.py#L2098
  2. useless-suppression:
    Useless suppression of 'no-member'
    https://github.com/cuthbertLab/music21/blob/e05fc53dfef7b2c9ac974c0cacb8b85e9c4d4605/music21/derivation.py#L246
  3. useless-suppression:
    Useless suppression of 'attribute-defined-outside-init'
    https://github.com/cuthbertLab/music21/blob/e05fc53dfef7b2c9ac974c0cacb8b85e9c4d4605/music21/chord/__init__.py#L4198

The following messages are no longer emitted:

  1. suppressed-message:
    Suppressed 'attribute-defined-outside-init' (from line 2098)
    https://github.com/cuthbertLab/music21/blob/e05fc53dfef7b2c9ac974c0cacb8b85e9c4d4605/music21/note.py#L2098
  2. suppressed-message:
    Suppressed 'no-member' (from line 246)
    https://github.com/cuthbertLab/music21/blob/e05fc53dfef7b2c9ac974c0cacb8b85e9c4d4605/music21/derivation.py#L246
  3. suppressed-message:
    Suppressed 'attribute-defined-outside-init' (from line 4198)
    https://github.com/cuthbertLab/music21/blob/e05fc53dfef7b2c9ac974c0cacb8b85e9c4d4605/music21/chord/__init__.py#L4198

Effect on django:
The following messages are now emitted:

  1. too-many-instance-attributes:
    Too many instance attributes (14/7)
    https://github.com/django/django/blob/1857b6663b664847a426e8c79b8aec42994660ba/django/db/models/query.py#L274

The following messages are no longer emitted:

  1. redefined-variable-type:
    Redefinition of url type from str to django.utils.safestring.SafeString
    https://github.com/django/django/blob/1857b6663b664847a426e8c79b8aec42994660ba/django/template/defaulttags.py#L490
  2. too-many-instance-attributes:
    Too many instance attributes (26/7)
    https://github.com/django/django/blob/1857b6663b664847a426e8c79b8aec42994660ba/django/db/models/query.py#L274
  3. not-callable:
    self.select_for_update is not callable
    https://github.com/django/django/blob/1857b6663b664847a426e8c79b8aec42994660ba/django/db/models/query.py#L967
  4. method-hidden:
    An attribute defined in django.db.models.query line 1165 hides this method
    https://github.com/django/django/blob/1857b6663b664847a426e8c79b8aec42994660ba/django/db/models/query.py#L1542
  5. method-hidden:
    An attribute defined in django.db.models.query line 1166 hides this method
    https://github.com/django/django/blob/1857b6663b664847a426e8c79b8aec42994660ba/django/db/models/query.py#L1558
  6. attribute-defined-outside-init:
    Attribute 'combined_queries' defined outside init
    https://github.com/django/django/blob/1857b6663b664847a426e8c79b8aec42994660ba/django/db/models/query.py#L1509
  7. attribute-defined-outside-init:
    Attribute 'combinator' defined outside init
    https://github.com/django/django/blob/1857b6663b664847a426e8c79b8aec42994660ba/django/db/models/query.py#L1512
  8. attribute-defined-outside-init:
    Attribute 'combinator_all' defined outside init
    https://github.com/django/django/blob/1857b6663b664847a426e8c79b8aec42994660ba/django/db/models/query.py#L1513
  9. attribute-defined-outside-init:
    Attribute 'select_for_update_nowait' defined outside init
    https://github.com/django/django/blob/1857b6663b664847a426e8c79b8aec42994660ba/django/db/models/query.py#L1552
  10. attribute-defined-outside-init:
    Attribute 'select_for_update_skip_locked' defined outside init
    https://github.com/django/django/blob/1857b6663b664847a426e8c79b8aec42994660ba/django/db/models/query.py#L1553
  11. attribute-defined-outside-init:
    Attribute 'select_for_update_of' defined outside init
    https://github.com/django/django/blob/1857b6663b664847a426e8c79b8aec42994660ba/django/db/models/query.py#L1554
  12. attribute-defined-outside-init:
    Attribute 'select_for_no_key_update' defined outside init
    https://github.com/django/django/blob/1857b6663b664847a426e8c79b8aec42994660ba/django/db/models/query.py#L1555
  13. attribute-defined-outside-init:
    Attribute 'group_by' defined outside init
    https://github.com/django/django/blob/1857b6663b664847a426e8c79b8aec42994660ba/django/db/models/query.py#L1671
  14. attribute-defined-outside-init:
    Attribute 'standard_ordering' defined outside init
    https://github.com/django/django/blob/1857b6663b664847a426e8c79b8aec42994660ba/django/db/models/query.py#L1722
  15. attribute-defined-outside-init:
    Attribute 'filter_is_sticky' defined outside init
    https://github.com/django/django/blob/1857b6663b664847a426e8c79b8aec42994660ba/django/db/models/query.py#L1886

Effect on pandas:
The following messages are no longer emitted:

  1. redefined-variable-type:
    Redefinition of result type from pandas.core.indexes.base.Index to .ndarray
    https://github.com/pandas-dev/pandas/blob/f1e6cc184ae0534e11c0a2947f4948bc4c5e0a9d/pandas/core/indexes/base.py#L3089
  2. redefined-variable-type:
    Redefinition of other type from int to bool
    https://github.com/pandas-dev/pandas/blob/f1e6cc184ae0534e11c0a2947f4948bc4c5e0a9d/pandas/core/arrays/masked.py#L730

Effect on sentry:
The following messages are no longer emitted:

  1. use-implicit-booleaness-not-len:
    Do not use len(SEQUENCE) without comparison to determine if a sequence is empty
    https://github.com/getsentry/sentry/blob/0c446e45c7cbcf2419d8d5d6cee7425c181e10ed/src/sentry/runner/commands/cleanup.py#L247

This comment was generated for commit 2cbaed1

Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice primer ! 😄

@Pierre-Sassoulas Pierre-Sassoulas merged commit 78f3dfa into main Sep 20, 2024
48 checks passed
@Pierre-Sassoulas Pierre-Sassoulas deleted the jtw/bump-astroid-333 branch September 20, 2024 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Maintenance Discussion or action around maintaining pylint or the dev workflow Skip news 🔇 This change does not require a changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants