Change order of search path to fix inconsistency between pylint and astroid.

[akamat10]

Type of Changes

	Type
✓	🐛 Bug fix

Description

While testing pylint-dev/pylint#9967, I noticed that the qualified package names are incorrect when linted files are outside of the source-roots specified. This PR changes the priority of the search path which then correctly picks up the right qualified module name. It makes sense to give higher priority to the additional search paths over sys.path. This is in line with priority order of expand_modules function in pylint. Hopefully the maintainers agree that this inconsistency needs to be fixed.

Refs pylint-dev/pylint#9955

[akamat10]

Also, both expand_module in pylint and modpath_from_file_with_callback in astroid are taking sys.path for module discovery with expand_module calling modpath_from_file_with_callback. It may be makes sense to simplify such that it is only happening in one of these functions

[Pierre-Sassoulas]

Yeah let's make pylint rely on astroid's fonction or at least comment on the similarity if we want to reduce coupling.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.24%. Comparing base (62c5bad) to head (0a8ebeb).

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2589   +/-   ##
=======================================
  Coverage   93.24%   93.24%           
=======================================
  Files          93       93           
  Lines       11067    11067           
=======================================
  Hits        10319    10319           
  Misses        748      748           

Flag	Coverage Δ
linux	93.12% <100.00%> (ø)
pypy	93.24% <100.00%> (ø)
windows	93.22% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
astroid/modutils.py	89.47% <100.00%> (ø)

[akamat10]

Great! Let me add a test with this PR before this is merged.