Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inference regression with property setters #2567

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

jacobtylerwalls
Copy link
Member

Type of Changes

Type
βœ“ πŸ› Bug fix

Description

Closes pylint-dev/pylint#9811

Copy link

codecov bot commented Sep 19, 2024

Codecov Report

All modified and coverable lines are covered by tests βœ…

Project coverage is 93.06%. Comparing base (709f991) to head (55c6199).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2567   +/-   ##
=======================================
  Coverage   93.05%   93.06%           
=======================================
  Files          93       93           
  Lines       11050    11060   +10     
=======================================
+ Hits        10283    10293   +10     
  Misses        767      767           
Flag Coverage Ξ”
linux 92.94% <100.00%> (+<0.01%) ⬆️
pypy 93.06% <100.00%> (+<0.01%) ⬆️
windows 93.04% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Ξ”
astroid/nodes/scoped_nodes/scoped_nodes.py 93.19% <100.00%> (+0.05%) ⬆️

@jacobtylerwalls jacobtylerwalls merged commit 5a93a9f into main Sep 19, 2024
22 checks passed
@jacobtylerwalls jacobtylerwalls deleted the jtw/inference-regression-property-setter branch September 19, 2024 12:43
Copy link
Contributor

The backport to maintenance/3.3.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-maintenance/3.3.x maintenance/3.3.x
# Navigate to the new working tree
cd .worktrees/backport-maintenance/3.3.x
# Create a new branch
git switch --create backport-2567-to-maintenance/3.3.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 5a93a9f9e7e8d1cbcbfc93783e86572b6c678152
# Push it to GitHub
git push --set-upstream origin backport-2567-to-maintenance/3.3.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-maintenance/3.3.x

Then, create a pull request where the base branch is maintenance/3.3.x and the compare/head branch is backport-2567-to-maintenance/3.3.x.

jacobtylerwalls added a commit to jacobtylerwalls/astroid that referenced this pull request Sep 19, 2024
jacobtylerwalls added a commit that referenced this pull request Sep 19, 2024
@jacobtylerwalls jacobtylerwalls added backported Assigned once the backport is done and removed backport maintenance/3.3.x labels Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backported Assigned once the backport is done Bug πŸͺ³
Projects
None yet
Development

Successfully merging this pull request may close these issues.

False positive for no-member with property setters
2 participants