Let is_lambda stay False for FunctionDef #2220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielNoord
previously approved these changes
Jun 22, 2023
jacobtylerwalls
commented
Jun 22, 2023
jacobtylerwalls
force-pushed
the
lambda-followup
branch
from
7d8b7c8
to
cea9b6c
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2220 +/- ##
=======================================
Coverage 92.82% 92.83%
=======================================
Files 94 94
Lines 10930 10957 +27
=======================================
+ Hits 10146 10172 +26
- Misses 784 785 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
jacobtylerwalls
force-pushed
the
lambda-followup
branch
from
cea9b6c
to
ae5d22f
Compare
jacobtylerwalls
force-pushed
the
lambda-followup
branch
from
ae5d22f
to
18c3d83
Compare
jacobtylerwalls
commented
Jul 4, 2023
Comment on lines
+1502
to
+1503
| # Want an intersecting member that is neither in a lambda nor a function | ||
| return bool(yields_without_lambdas & yields_without_functions) |
There was a problem hiding this comment.
This is what necessitated all those new methods, given that FunctionDefs are no longer lambdas... (lol) we can't just skip lambdas only.
Pierre-Sassoulas
approved these changes
Jul 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
Follow-up to 1a14b5d.