Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Add tests in pyhf-validation-root-base Docker image #9

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

ci: Add tests in pyhf-validation-root-base Docker image #9

wants to merge 14 commits into from

Commits on Nov 17, 2020

  1. Add tests in pyhf-validation-root-base Docker image 

    * Uses the 'container' option

c.f.
- https://help.github.com/en/actions/reference/workflow-syntax-for-github-actions#jobsjob_idcontainer
- https://github.com/github/actions-cheat-sheet/blob/master/actions-cheat-sheet.adoc#workflow-syntax
    @matthewfeickert
    matthewfeickert committed Nov 17, 2020
    Configuration menu
    Copy the full SHA
    e4e2ef1 View commit details
    Browse the repository at this point in the history

  2. Add comment explaining 'git init .'

    @matthewfeickert
    matthewfeickert committed Nov 17, 2020
    Configuration menu
    Copy the full SHA
    a9896ec View commit details
    Browse the repository at this point in the history

  3. Add JSON to workspace converter script

    @matthewfeickert
    matthewfeickert committed Nov 17, 2020
    Configuration menu
    Copy the full SHA
    9e5723c View commit details
    Browse the repository at this point in the history

  4. Add JSON to workspace converter test to CI

    @matthewfeickert
    matthewfeickert committed Nov 17, 2020
    Configuration menu
    Copy the full SHA
    7334751 View commit details
    Browse the repository at this point in the history

  5. Remove commented out run examples

    @matthewfeickert
    matthewfeickert committed Nov 17, 2020
    Configuration menu
    Copy the full SHA
    dda8ac5 View commit details
    Browse the repository at this point in the history

  6. Simplify logic on dir creation

    @matthewfeickert
    matthewfeickert committed Nov 17, 2020
    Configuration menu
    Copy the full SHA
    efe8c61 View commit details
    Browse the repository at this point in the history

  7. split out workspace generation and testing

    @matthewfeickert
    matthewfeickert committed Nov 17, 2020
    Configuration menu
    Copy the full SHA
    b6b8d8f View commit details
    Browse the repository at this point in the history

  8. Fix ordering for replacement 

    the replacement is of ROOT named parameters to be named like pyhf
parameters
    @matthewfeickert
    matthewfeickert committed Nov 17, 2020
    Configuration menu
    Copy the full SHA
    59b370c View commit details
    Browse the repository at this point in the history

  9. Lint shell scripts with shellcheck

    @matthewfeickert
    matthewfeickert committed Nov 17, 2020
    Configuration menu
    Copy the full SHA
    5bb1375 View commit details
    Browse the repository at this point in the history

  10. Drop redundant install of git 

    Git is already installed in the base image
    @matthewfeickert
    matthewfeickert committed Nov 17, 2020
    Configuration menu
    Copy the full SHA
    1390f99 View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2020

  1. Use root6.22.02 release tag 

    significantly smaller
    @matthewfeickert
    matthewfeickert committed Nov 18, 2020
    Configuration menu
    Copy the full SHA
    546fd4a View commit details
    Browse the repository at this point in the history

  2. Correct name

    @matthewfeickert
    matthewfeickert committed Nov 18, 2020
    Configuration menu
    Copy the full SHA
    13cb617 View commit details
    Browse the repository at this point in the history

  3. Update to use modern pyhf CLI tooling

    @matthewfeickert
    matthewfeickert committed Nov 18, 2020
    Configuration menu
    Copy the full SHA
    23ade2a View commit details
    Browse the repository at this point in the history

  4. Correct paths

    @matthewfeickert
    matthewfeickert committed Nov 18, 2020
    Configuration menu
    Copy the full SHA
    2ae3c60 View commit details
    Browse the repository at this point in the history