Add bezier from gfxdraw module to draw module

[bilhox]

Hello, as part of #3005 plan, this PR moves pygame.gfxdraw.bezier to pygame.draw.bezier.

[damusss]

This note is outdated.

[MyreMylar]

OK, LGTM. Bezier works as expected under the draw module instead of gfxdraw in my testing. the tests all pass locally as well.

Test program:

import pygame

pygame.init()

sf = pygame.display.set_mode((640, 480))

font = pygame.font.Font(size=36)

points = []

STEPS = 3

print("Click on the screen to put points.")

while 1:
    for event in pygame.event.get():
        if event.type == pygame.MOUSEBUTTONDOWN:
            points.append(event.pos)
    sf.fill((0, 0, 0))

    for p in points:
        pygame.draw.circle(sf, (255, 0, 0), p, 5)

    if len(points) > 2:
        pygame.draw.lines(sf, (255, 0, 0), False, points)
        pygame.draw.bezier(sf, points, STEPS, (255, 255, 255))

    test = f"Points: {len(points)}\nSteps: {STEPS}"
    text_sf = font.render(test, True, (255, 255, 255))
    sf.blit(text_sf, (10, 400))

    pygame.display.update()

[bilhox]

I would like to know your opinion about the step argument before potentially merging it. I think personally the docs are not clear at all about step argument, and when I tested it with different values, I couldn't really figure out how it was used. Furthermore the code is not that great to read (I first look the variable names are not understandable), which is why I support the idea of a new implementation of Bézier curves so I can also document the terrible code.

[MyreMylar]

I would like to know your opinion about the step argument before potentially merging it. I think personally the docs are not clear at all about step argument, and when I tested it with different values, I couldn't really figure out how it was used. Furthermore the code is not that great to read (I first look the variable names are not understandable), which is why I support the idea of a new implementation of Bézier curves so I can also document the terrible code.

My main feeling is that we should try and get this merged so we can shim & steadily get rid of gfxdraw from docs and examples and the like.

However, if you think the step argument is the least reliable argument in a future implementation of bezier line drawing then what I would do is move it to the end of the function signature instead of before the color argument, and make sure it has a default value specified so it is optional. You could also make it a keyword argument only parameter too.

That way in the future it will be much easier to remove or alter the step argument while still allowing us to handle it as it is right now and make a convenient gfxdraw shim for it.

So, to be clear the function signature (in python) would be something like:

def bezier(Surface surface, Sequence[Point] points, ColorLike color, *,  int step=3)