Merge pull request #463 from bashtage/new-google-urls

New google urls
pydata · Jan 21, 2018 · 747a67b · 747a67b
2 parents dcc09eb + 833d6a3
commit 747a67b
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 3 deletions.
diff --git a/pandas_datareader/google/daily.py b/pandas_datareader/google/daily.py
@@ -44,7 +44,7 @@ def __init__(self, symbols=None, start=None, end=None, retry_count=3,
 
     @property
     def url(self):
-        return 'http://finance.google.com/finance/historical'
+        return 'https://finance.google.com/finance/historical'
 
     def _get_params(self, symbol):
         params = {

diff --git a/pandas_datareader/google/quotes.py b/pandas_datareader/google/quotes.py
@@ -15,7 +15,7 @@ class GoogleQuotesReader(_BaseReader):
 
     @property
     def url(self):
-        return 'http://www.google.com/finance/info'
+        return 'https://finance.google.com/finance/info'
 
     @property
     def params(self):

diff --git a/pandas_datareader/tests/test_iex.py b/pandas_datareader/tests/test_iex.py
@@ -45,4 +45,7 @@ def test_live_prices(self):
 
     def test_deep(self):
         dob = get_iex_book('GS', service='book')
-        assert 'GS' in dob
+        if dob:
+            assert 'GS' in dob
+        else:
+            pytest.xfail(reason='Can only get Book when market open')