Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Latitude and Longitude evaluated #90

Merged
merged 2 commits into from
Aug 25, 2023
Merged

Conversation

Kludex
Copy link
Member

@Kludex Kludex commented Aug 25, 2023

Since Latitude and Longitude are lazily evaluated, we have the issue described in the issue. 😅

Selected Reviewer: @yezz123

@Kludex
Copy link
Member Author

Kludex commented Aug 25, 2023

please review

@Kludex Kludex requested review from lig and hramezani August 25, 2023 11:48
@codecov
Copy link

codecov bot commented Aug 25, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (7712714) 100.00% compared to head (2ec733f) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #90   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            8         8           
  Lines          599       598    -1     
  Branches       152       152           
=========================================
- Hits           599       598    -1     
Files Changed Coverage Δ
pydantic_extra_types/coordinate.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Kludex Kludex merged commit 874bd77 into main Aug 25, 2023
20 checks passed
@Kludex Kludex deleted the fix/latitude-longitude-future branch August 25, 2023 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Coordinate cannot be used as optional field
3 participants