fix: Use field translation in Jira.issue method #1864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wojtini
changed the title
Wojtini
changed the title
adehad
reviewed
Sep 2, 2024
jira/client.py
Outdated
Comment on lines
3611
to
3612
| if not translation_map: | ||
| return |
There was a problem hiding this comment.
do we want to move this out of a staticmethod and instead have a cache of the the translation_map inside the class instance? ie similar to what is done with the self._field_cache ?
|
Label error. Requires exactly 1 of: bug, enhancement, major, minor, patch, skip-changelog. Found: |
Wojtini
force-pushed
the
wojtini_fix_get_issue_customfields
branch
from
77f3aa9
to
8ad5bc6
Compare
Wojtini
force-pushed
the
wojtini_fix_get_issue_customfields
branch
from
b304904
to
10afa59
Compare
Wojtini
force-pushed
the
wojtini_fix_get_issue_customfields
branch
from
f977b18
to
10afa59
Compare
Wojtini
force-pushed
the
wojtini_fix_get_issue_customfields
branch
from
be0f572
to
8ad5bc6
Compare
Wojtini
force-pushed
the
wojtini_fix_get_issue_customfields
branch
from
b10d222
to
8ad5bc6
Compare
Wojtini
force-pushed
the
wojtini_fix_get_issue_customfields
branch
from
8ad5bc6
to
eb0ec90
Compare
Wojtini
force-pushed
the
wojtini_fix_get_issue_customfields
branch
from
c29146c
to
6a14b06
Compare
Wojtini
force-pushed
the
wojtini_fix_get_issue_customfields
branch
from
4666201
to
6a14b06
Compare
Wojtini
force-pushed
the
wojtini_fix_get_issue_customfields
branch
from
786a4e2
to
6a14b06
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fields param in issue are untranslated so if you use custom_field's name instead of id Jira API won't return it. Those changes are supposed to fix that.
Changes: