Adds support for OSC hyperlink sequences. #131
Conversation
ansi2html/converter.py
Outdated
| yield part | ||
| else: | ||
| if ((sys.version_info.major == 3 and sys.version_info.minor >= 3) | ||
| or sys.version_info.major > 3): |
There was a problem hiding this comment.
This makes no sense because we already require py36+, please remove variant for relic-pythons.
There was a problem hiding this comment.
Thanks for the comment, I have removed the check in a new commit.
hakonhagland
force-pushed
the
osc_link
branch
from
b6278dc
to
364e171
Compare
|
@hakonhagland Linting is failing. I also sent you an invite https://github.com/pycontribs/ansi2html/invitations so you will not have to wait for me to approve CI executions. PS. I could really use some help with #135 |
Adds support for OSC hyperlink sequences.
Since the module requires python 3.6 and "yield from" was introduced in 3.3, there is no need for this check.
pylint throws R1705: Unnecessary "else" after "return" (no-else-return).
hakonhagland
force-pushed
the
osc_link
branch
from
364e171
to
5416551
Compare
@ssbarnea I added a new commit to fix this.
Thanks! I have accepted the invite. I am quite new to Python, so I will use this as a learning experience.
I will try to help but I am not familiar with all the testing and GitHub actions yet.. Is there anything in particular I should look at? |
|
Any idea why the linter is failing now? |
|
@hakonhagland Yes. Just run "tox -e lint" locally and include the modified files in your change. black is reformatting the code so you do not have to think about how to follow the style guide too much. |
Ran "tox -e lint" and committed the changes it did.
Fixes #130 : adds support for OSC hyperlink sequences.