Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

❤️‍🩹 Looking for maintainers! #135

Open
ssbarnea opened this issue Sep 1, 2021 · 17 comments
Open

❤️‍🩹 Looking for maintainers! #135

ssbarnea opened this issue Sep 1, 2021 · 17 comments

Comments

@ssbarnea
Copy link
Member

ssbarnea commented Sep 1, 2021

This project could really benefit from some love. I am looking for others that are willing to help maintaining it as my time is very limited these days.

Please state your interest here, I am more than happy to add new contributors to the project.

@ssbarnea ssbarnea changed the title Looking for maintainers! ❤️‍🩹 Looking for maintainers! Sep 1, 2021
@iofq
Copy link

iofq commented Oct 4, 2021

@ssbarnea I would be interested in helping out. I have some knowledge of python, as well as some knowledge of bash & CI. Let me know how I can assist!

@abitrolly
Copy link

I would make it a single executable file, which can be just copied without installation.

@ssbarnea
Copy link
Member Author

@abitrolly Probably you can look into projects that aim to do this by packaging python, deps into executables but the project itself will still be a python library. I doubt we will ever start publishing binaries for it on each platform, is a "bit" out of scope.

@abitrolly
Copy link

The idea is to have a single executable ansi2html.py, not binaries.

@ssbarnea
Copy link
Member Author

The library already has 5 files and combining them together would not make it easier to maintain. If you want to create a single file you can look at various projects that aim to do this. Lucky for us we do not really have external dependencies.

Still, i do not think that the project itself would benefit from that.

@abitrolly
Copy link

There are five files.

Keeping styling code separate from parser kind of makes sense, but for me having a single file that I can drag and drop in my project has some utility value as serving a replacement for ansi2html.sh.

@ssbarnea
Copy link
Member Author

You may want to investigate pipx, py2exe or other similar projects that can help you encapsulate python code. Lets avoid polluting this thread with this feature request. You are welcomed to create a feature request for it but I doubt we will do it.

@hartwork
Copy link
Collaborator

Hi @ssbarnea I'm a past contributer and happy to team up on things ansi2html.

@echuber2
Copy link
Collaborator

@hartwork If you're a veteran, I'd appreciate your thoughts on #126

@ssbarnea
Copy link
Member Author

ssbarnea commented Feb 1, 2022

@hartwork welcome back! Check https://github.com/pycontribs/ansi2html/invitations and that will give you maintain role.

@hartwork
Copy link
Collaborator

hartwork commented Feb 1, 2022

@ssbarnea thank you! 🙏

@jeffwright13
Copy link
Collaborator

Hey - are you still looking for some help? I am the author of pytest-tui, and I have started using your library as a way to write the console output from Pytest to HTML. I might be able to contribute.

@hartwork
Copy link
Collaborator

There are definitely open issues that could use more hands with analysis and fixing.

@ssbarnea
Copy link
Member Author

I am more than happy to help you takeover maintenance and I will provide help. Main focus is to keep CI/CD (GHA) green, which usually involves some changes from time to time.

Best is to ping me on matrix/irc so we can address things in real time.

@jeffwright13
Copy link
Collaborator

I feel dumb, but I don't know what matrix is. I do know what irc is but - what channel? Where?

@ssbarnea
Copy link
Member Author

ssbarnea commented Aug 1, 2022

@jeffwright13 Check https://github.com/ssbarnea for links to these channels. In fact even google chat with my email should work but i might little bit longer time for me to reply there.

@jeffwright13
Copy link
Collaborator

Sorry for the late reply, I was out of town. I will check out the link above and reach out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants