Draft: page label feature #1188
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lucas-C
reviewed
Jun 12, 2024
Lucas-C
reviewed
Jun 12, 2024
Lucas-C
reviewed
Jun 12, 2024
Lucas-C
reviewed
Jun 12, 2024
Comment on lines
+871
to
+873
| label_style=None, | ||
| label_prefix=None, | ||
| label_start=None, |
There was a problem hiding this comment.
Just a reminder that in the end, some doctring should be added for those 🙂
|
This is really promising, good job @andersonhc 👍 🙂 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1188 +/- ##
==========================================
- Coverage 93.25% 92.96% -0.29%
==========================================
Files 30 31 +1
Lines 9253 9699 +446
Branches 2104 2171 +67
==========================================
+ Hits 8629 9017 +388
- Misses 385 432 +47
- Partials 239 250 +11 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements "Page label" feature in fpdf2.
Checklist:
Implement page label
Create method to read page labels if the user wants to use on header, footer, etc.
Add option on TOC to list page labels instead of page number
The GitHub pipeline is OK (green),
meaning that both
pylint(static code analyzer) andblack(code formatter) are happy with the changes of this PR.A unit test is covering the code added / modified by this PR
This PR is ready to be merged
In case of a new feature, docstrings have been added, with also some documentation in the
docs/folderA mention of the change is present in
CHANGELOG.mdBy submitting this pull request, I confirm that my contribution is made under the terms of the GNU LGPL 3.0 license.