Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Python version 3.8 #2213

Merged
merged 11 commits into from
Sep 25, 2024
Merged
Show file tree
Hide file tree
Changes from 10 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ jobs:
- name: Set up Python
uses: actions/setup-python@v2
with:
python-version: 3.8
python-version: 3.9

- name: Install build tools
run: |
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/pytest-remote-data.yml
Original file line number Diff line number Diff line change
Expand Up @@ -56,10 +56,10 @@ jobs:
strategy:
fail-fast: false # don't cancel other matrix jobs when one fails
matrix:
python-version: [3.8, 3.9, "3.10", "3.11", "3.12"]
python-version: [3.9, "3.10", "3.11", "3.12"]
suffix: [''] # the alternative to "-min"
include:
- python-version: 3.8
- python-version: 3.9
suffix: -min

runs-on: ubuntu-latest
Expand Down Expand Up @@ -103,7 +103,7 @@ jobs:
run: pytest pvlib/tests/iotools --cov=./ --cov-report=xml --remote-data

- name: Upload coverage to Codecov
if: matrix.python-version == 3.8 && matrix.suffix == ''
if: matrix.python-version == 3.9 && matrix.suffix == ''
uses: codecov/codecov-action@v4
with:
fail_ci_if_error: true
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/pytest.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,12 +12,12 @@ jobs:
fail-fast: false # don't cancel other matrix jobs when one fails
matrix:
os: [ubuntu-latest, macos-latest, windows-latest]
python-version: [3.8, 3.9, "3.10", "3.11", "3.12"]
python-version: [3.9, "3.10", "3.11", "3.12"]
environment-type: [conda, bare]
suffix: [''] # placeholder as an alternative to "-min"
include:
- os: ubuntu-latest
python-version: 3.8
python-version: 3.9
environment-type: conda
suffix: -min
exclude:
Expand Down Expand Up @@ -82,7 +82,7 @@ jobs:
pytest pvlib --cov=./ --cov-report=xml --ignore=pvlib/tests/iotools

- name: Upload coverage to Codecov
if: matrix.python-version == 3.8 && matrix.suffix == '' && matrix.os == 'ubuntu-latest' && matrix.environment-type == 'conda'
if: matrix.python-version == 3.9 && matrix.suffix == '' && matrix.os == 'ubuntu-latest' && matrix.environment-type == 'conda'
uses: codecov/codecov-action@v4
with:
fail_ci_if_error: true
Expand Down
10 changes: 5 additions & 5 deletions benchmarks/asv.conf.json
Original file line number Diff line number Diff line change
Expand Up @@ -113,19 +113,19 @@
"include": [
// minimum supported versions
{
"python": "3.8",
"python": "3.9",
"build": "",
"numpy": "1.17.5",
"numpy": "1.19.5",
"pandas": "1.3.0",
"scipy": "1.6.0",
// Note: these don't have a minimum in setup.py
"h5py": "3.1.0",
"ephem": "3.7.7.0", // first version to support py 3.8
"numba": "0.47.0", // first version to support py 3.8
"ephem": "4.0.0.1", // first version to support py 3.9
"numba": "0.53.0", // first version to support py 3.9
},
// latest versions available
{
"python": "3.8",
"python": "3.9",
"build": "",
"numpy": "",
"pandas": "",
Expand Down
28 changes: 0 additions & 28 deletions ci/requirements-py3.8.yml

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -8,14 +8,14 @@ dependencies:
- pytest-cov
- pytest-mock
- pytest-timeout
- python=3.8
- python=3.9
- pytz
- requests
- pip:
- dataclasses
AdamRJensen marked this conversation as resolved.
Show resolved Hide resolved
- h5py==2.10.0 # chosen for compatibility with numpy 1.17.3 and py3.8
- numpy==1.17.3
- pandas==1.3.0
- h5py==3.0.0
- numpy==1.19.3
- pandas==1.3.0 # min version of pvlib
- scipy==1.6.0
- pytest-rerunfailures # conda version is >3.6
- pytest-remotedata # conda package is 0.3.0, needs > 0.3.1
Expand Down
6 changes: 4 additions & 2 deletions docs/sphinx/source/whatsnew/v0.11.1.rst
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,8 @@ Documentation

Requirements
~~~~~~~~~~~~

* Python 3.9 or greater. (:pull:`2213`)
* Minimum numpy version increased to v1.19.3. (:pull:`2213`)

Contributors
~~~~~~~~~~~~
Expand All @@ -98,4 +99,5 @@ Contributors
* Marcos R. Escudero (:ghuser:`marc-resc`)
* Bernat Nicolau (:ghuser:`BernatNicolau`)
* Eduardo Sarquis (:ghuser:`EduardoSarquis`)
* Andrew B Godbehere (:ghuser:`agodbehere`)
* Adam R. Jensen (:ghuser:`AdamRJensen`)
* Andrew B Godbehere (:ghuser:`agodbehere`)
4 changes: 2 additions & 2 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,9 @@ description = "A set of functions and classes for simulating the performance of
authors = [
{ name = "pvlib python Developers", email = "[email protected]" },
]
requires-python = ">=3.8"
requires-python = ">=3.9"
dependencies = [
'numpy >= 1.17.3',
'numpy >= 1.19.3',
'pandas >= 1.3.0',
'pytz',
'requests',
Expand Down
Loading