Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle time normalization for nonexistent and ambiguous times #2133
base: main
Are you sure you want to change the base?
Handle time normalization for nonexistent and ambiguous times #2133
Changes from 10 commits
30bb319
6000bb2
6354443
2348afd
844a8b0
92b1d28
5b79e00
f271274
2466e7b
4ed2315
104bb23
5f85c32
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about this with the modification of
def hour_angle(times, longitude, equation_of_time)
intodef hour_angle(times, longitude, equation_of_time, nonexistent='shift_forward', ambiguous='raise')
to give users a choice to control thetz_localize
behavior if they want rather than just receiving an error and being blocked?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@scttnlsn could you comment on this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The user would not necessarily be blocked if the exception is raised. They'd just need to convert the given times to a non-DST timezone ahead of calling
hour_angle
. The documentation is updated to mention this.infer
won't really work as mentioned here: #2133 (comment) The other options are toraise
(current approach) or to haveNaN
s returned where the times are ambiguous (the user still likely needs to deal with that case).I'm personally of the opinion that forcing the user to convert to a non-DST timezone is a fine approach but I could understand someone might want to have
NaN
s instead.