Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lcoe branch #1687

Open
wants to merge 50 commits into
base: main
Choose a base branch
from
Open

Lcoe branch #1687

wants to merge 50 commits into from

Commits on Mar 6, 2023

  1. ''

    @eccoope
    eccoope committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    49fd4e8 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' of https://github.com/eccoope/pvlib-python-forked … 

    …into lcoe_branch
    @eccoope
    eccoope committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    fb6ff2f View commit details
    Browse the repository at this point in the history

  3. ''

    @eccoope
    eccoope committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    2204f18 View commit details
    Browse the repository at this point in the history

Commits on Mar 7, 2023

  1. resolved stickler issues

    @eccoope
    eccoope authored Mar 7, 2023
    Configuration menu
    Copy the full SHA
    af4b00b View commit details
    Browse the repository at this point in the history

  2. resolved stickler issues

    @eccoope
    eccoope authored Mar 7, 2023
    Configuration menu
    Copy the full SHA
    d7c606d View commit details
    Browse the repository at this point in the history

  3. resolved stickler issues

    @eccoope
    eccoope authored Mar 7, 2023
    Configuration menu
    Copy the full SHA
    9b86e11 View commit details
    Browse the repository at this point in the history

  4. updated to be consistent suggested changes 

    mikeofski recommended not rounding returns in the financial.py module, tests needed to be updated for expected to match out
    @eccoope
    eccoope authored Mar 7, 2023
    Configuration menu
    Copy the full SHA
    9f1e090 View commit details
    Browse the repository at this point in the history

  5. ''

    @eccoope
    eccoope committed Mar 7, 2023
    Configuration menu
    Copy the full SHA
    a4fa101 View commit details
    Browse the repository at this point in the history

  6. ''

    @eccoope
    eccoope committed Mar 7, 2023
    Configuration menu
    Copy the full SHA
    fdea1b5 View commit details
    Browse the repository at this point in the history

  7. ''

    @eccoope
    eccoope committed Mar 7, 2023
    Configuration menu
    Copy the full SHA
    4c7cba8 View commit details
    Browse the repository at this point in the history

  8. ''

    @eccoope
    eccoope committed Mar 7, 2023
    Configuration menu
    Copy the full SHA
    7fdb96f View commit details
    Browse the repository at this point in the history

  9. ''

    @eccoope
    eccoope committed Mar 7, 2023
    Configuration menu
    Copy the full SHA
    59df950 View commit details
    Browse the repository at this point in the history

  10. ''

    @eccoope
    eccoope committed Mar 7, 2023
    Configuration menu
    Copy the full SHA
    effdaa7 View commit details
    Browse the repository at this point in the history

Commits on Mar 8, 2023

  1. Resolve stickler failures

    @eccoope
    eccoope authored Mar 8, 2023
    Configuration menu
    Copy the full SHA
    4284990 View commit details
    Browse the repository at this point in the history

  2. Resolved stickler issues in simple_lcoe_calculator.py

    @eccoope
    eccoope authored Mar 8, 2023
    Configuration menu
    Copy the full SHA
    2bfba2e View commit details
    Browse the repository at this point in the history

  3. Resolved stickler issues and linked references

    @eccoope
    eccoope authored Mar 8, 2023
    Configuration menu
    Copy the full SHA
    e6f6938 View commit details
    Browse the repository at this point in the history

  4. Resolved stickler failures

    @eccoope
    eccoope authored Mar 8, 2023
    Configuration menu
    Copy the full SHA
    b61a9cb View commit details
    Browse the repository at this point in the history

  5. Changed variable names + real/nominal clarification 

    Debt tenor was changed to analysis period as recommended by @brtietz, discount rate was clarified to be real
    @eccoope
    eccoope authored Mar 8, 2023
    Configuration menu
    Copy the full SHA
    49f2631 View commit details
    Browse the repository at this point in the history

  6. Resolved stickler failure 

    in lcoe_sam_validation.py
    @eccoope
    eccoope authored Mar 8, 2023
    Configuration menu
    Copy the full SHA
    388f9f4 View commit details
    Browse the repository at this point in the history

  7. More stickler corrections 

    financial.py
    @eccoope
    eccoope authored Mar 8, 2023
    Configuration menu
    Copy the full SHA
    a18f861 View commit details
    Browse the repository at this point in the history

  8. Encourage use of real discount rates 

    financial.py
    @eccoope
    eccoope authored Mar 8, 2023
    Configuration menu
    Copy the full SHA
    582c974 View commit details
    Browse the repository at this point in the history

  9. Encourage use of real discount rates 

    lcoe_sam_validation.py
    @eccoope
    eccoope authored Mar 8, 2023
    Configuration menu
    Copy the full SHA
    4161663 View commit details
    Browse the repository at this point in the history

Commits on Mar 9, 2023

  1. Update pvlib/financial.py 

    Formatting

Co-authored-by: Cliff Hansen <[email protected]>
    @eccoope @cwhanse
    eccoope and cwhanse authored Mar 9, 2023
    Configuration menu
    Copy the full SHA
    c0e31dc View commit details
    Browse the repository at this point in the history

  2. Update pvlib/financial.py 

    Formatting

Co-authored-by: Cliff Hansen <[email protected]>
    @eccoope @cwhanse
    eccoope and cwhanse authored Mar 9, 2023
    Configuration menu
    Copy the full SHA
    912969d View commit details
    Browse the repository at this point in the history

  3. Update pvlib/financial.py 

    Formatting - as suggested by @cwhanse

Co-authored-by: Cliff Hansen <[email protected]>
    @eccoope @cwhanse
    eccoope and cwhanse authored Mar 9, 2023
    Configuration menu
    Copy the full SHA
    a0a7cf1 View commit details
    Browse the repository at this point in the history

  4. Update pvlib/financial.py 

    Formatting - suggested by @cwhanse

Co-authored-by: Cliff Hansen <[email protected]>
    @eccoope @cwhanse
    eccoope and cwhanse authored Mar 9, 2023
    Configuration menu
    Copy the full SHA
    17898a6 View commit details
    Browse the repository at this point in the history

  5. Update pvlib/financial.py 

    Formatting, suggested by @cwhanse

Co-authored-by: Cliff Hansen <[email protected]>
    @eccoope @cwhanse
    eccoope and cwhanse authored Mar 9, 2023
    Configuration menu
    Copy the full SHA
    dce7e5f View commit details
    Browse the repository at this point in the history

  6. Update pvlib/financial.py 

    Formatting from @cwhanse

Co-authored-by: Cliff Hansen <[email protected]>
    @eccoope @cwhanse
    eccoope and cwhanse authored Mar 9, 2023
    Configuration menu
    Copy the full SHA
    1ea12b5 View commit details
    Browse the repository at this point in the history

  7. Update pvlib/financial.py 

    Formatting from @cwhanse

Co-authored-by: Cliff Hansen <[email protected]>
    @eccoope @cwhanse
    eccoope and cwhanse authored Mar 9, 2023
    Configuration menu
    Copy the full SHA
    e124027 View commit details
    Browse the repository at this point in the history

  8. Apply suggestions from code review 

    from @cwhanse

Co-authored-by: Cliff Hansen <[email protected]>
    @eccoope @cwhanse
    eccoope and cwhanse authored Mar 9, 2023
    Configuration menu
    Copy the full SHA
    9d17c09 View commit details
    Browse the repository at this point in the history

  9. Update financial.py 

    added lcoe formula to docstring
    @eccoope
    eccoope authored Mar 9, 2023
    Configuration menu
    Copy the full SHA
    83d6e02 View commit details
    Browse the repository at this point in the history

  10. Update test_financial.py 

    stickler issues
    @eccoope
    eccoope authored Mar 9, 2023
    Configuration menu
    Copy the full SHA
    33c8238 View commit details
    Browse the repository at this point in the history

Commits on Mar 10, 2023

  1. Stickler for lcoe_sam_validation.py

    @eccoope
    eccoope authored Mar 10, 2023
    Configuration menu
    Copy the full SHA
    cd0ae02 View commit details
    Browse the repository at this point in the history

  2. More stickler for lcoe_sam_validation.py

    @eccoope
    eccoope authored Mar 10, 2023
    Configuration menu
    Copy the full SHA
    92d7258 View commit details
    Browse the repository at this point in the history

  3. more stickler for lcoe_sam_validation.py 

    I think I've finally got it this time guys
    @eccoope
    eccoope authored Mar 10, 2023
    Configuration menu
    Copy the full SHA
    cae3d7b View commit details
    Browse the repository at this point in the history

  4. One last stickler thing

    @eccoope
    eccoope authored Mar 10, 2023
    Configuration menu
    Copy the full SHA
    7fc63e7 View commit details
    Browse the repository at this point in the history

  5. Remove "real" from wacc docstring 

    per @cwhanse 's recommendation
    @eccoope
    eccoope authored Mar 10, 2023
    Configuration menu
    Copy the full SHA
    00df4f8 View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2023

  1. Added a line to index.rst

    @eccoope
    eccoope committed Mar 15, 2023
    Configuration menu
    Copy the full SHA
    ab47596 View commit details
    Browse the repository at this point in the history

Commits on Mar 16, 2023

  1. Added last two authors to be consistent with version in main branch

    @eccoope
    eccoope authored Mar 16, 2023
    Configuration menu
    Copy the full SHA
    7a039b7 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into lcoe_branch

    @eccoope
    eccoope authored Mar 16, 2023
    Configuration menu
    Copy the full SHA
    ebec039 View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2023

  1. Merge branch 'main' of https://github.com/eccoope/pvlib-python-forked … 

    …into lcoe_branch
    @eccoope
    eccoope committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    7136b84 View commit details
    Browse the repository at this point in the history

  2. Resolved conflicts in v0.9.5 and moved changes to v0.9.6

    @eccoope
    eccoope committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    41bde9c View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into lcoe_branch

    @eccoope
    eccoope authored Jun 21, 2023
    Configuration menu
    Copy the full SHA
    8aff9f0 View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2023

  1. Remove variable O&M caveatp 

    per @mikofski 's rec
    @eccoope
    eccoope authored Jun 28, 2023
    Configuration menu
    Copy the full SHA
    925e155 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into lcoe_branch

    @eccoope
    eccoope authored Jun 28, 2023
    Configuration menu
    Copy the full SHA
    42b7823 View commit details
    Browse the repository at this point in the history

Commits on Jul 10, 2023

  1. Added system degradation rate to example 

    Using equation 2 from https://pubs.rsc.org/en/content/articlehtml/2011/ee/c0ee00698j#cit4
    @eccoope
    eccoope authored Jul 10, 2023
    Configuration menu
    Copy the full SHA
    0541e5b View commit details
    Browse the repository at this point in the history

  2. Delete v0.9.6.rst

    @eccoope
    eccoope authored Jul 10, 2023
    Configuration menu
    Copy the full SHA
    1441de6 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'pvlib:main' into lcoe_branch

    @eccoope
    eccoope authored Jul 10, 2023
    Configuration menu
    Copy the full SHA
    d2205c3 View commit details
    Browse the repository at this point in the history

  4. Updated whatsnew v0.10.2.rst

    @eccoope
    eccoope committed Jul 10, 2023
    Configuration menu
    Copy the full SHA
    77fb22c View commit details
    Browse the repository at this point in the history

Commits on Dec 13, 2023

  1. Merge branch 'main' into lcoe_branch

    @eccoope
    eccoope authored Dec 13, 2023
    Configuration menu
    Copy the full SHA
    b3c272e View commit details
    Browse the repository at this point in the history