Remove pvlib.forecast (#1766)

* delete forecast code and doc files * scrub test configuration * remove netcdf4, siphon, cftime dependencies * nix forecast notebooks * whatsnew
pvlib · Jun 23, 2023 · 9d8ca55 · 9d8ca55
1 parent e643dc3
commit 9d8ca55
Show file tree

Hide file tree

Showing 22 changed files with 13 additions and 9,849 deletions.
diff --git a/.github/workflows/pytest-remote-data.yml b/.github/workflows/pytest-remote-data.yml
@@ -100,7 +100,7 @@ jobs:
           SOLARANYWHERE_API_KEY: ${{ secrets.SOLARANYWHERE_API_KEY }}
           BSRN_FTP_USERNAME: ${{ secrets.BSRN_FTP_USERNAME }}
           BSRN_FTP_PASSWORD: ${{ secrets.BSRN_FTP_PASSWORD }}
-        run: pytest pvlib/tests/iotools pvlib/tests/test_forecast.py --cov=./ --cov-report=xml --remote-data
+        run: pytest pvlib/tests/iotools --cov=./ --cov-report=xml --remote-data
 
       - name: Upload coverage to Codecov
         if: matrix.python-version == 3.7 && matrix.suffix == ''

diff --git a/.github/workflows/pytest.yml b/.github/workflows/pytest.yml
@@ -78,8 +78,8 @@ jobs:
       - name: Run tests
         shell: bash -l {0}  # necessary for conda env to be active
         run: |
-          # ignore iotools & forecast; those tests are run in a separate workflow
-          pytest pvlib --cov=./ --cov-report=xml --ignore=pvlib/tests/iotools --ignore=pvlib/tests/test_forecast.py
+          # ignore iotools; those tests are run in a separate workflow
+          pytest pvlib --cov=./ --cov-report=xml --ignore=pvlib/tests/iotools
 
       - name: Upload coverage to Codecov
         if: matrix.python-version == 3.7 && matrix.suffix == '' && matrix.os == 'ubuntu-latest' && matrix.environment-type == 'conda'

diff --git a/ci/requirements-py3.10.yml b/ci/requirements-py3.10.yml
@@ -7,7 +7,6 @@ dependencies:
     - cython
     - ephem
     - h5py
-    - netcdf4
     - numba
     - numpy >= 1.16.0
     - pandas >= 0.25.0

diff --git a/ci/requirements-py3.11.yml b/ci/requirements-py3.11.yml
@@ -7,7 +7,6 @@ dependencies:
     - cython
     - ephem
     - h5py
-    - netcdf4
     - numba
     - numpy >= 1.16.0
     - pandas >= 0.25.0

diff --git a/ci/requirements-py3.7.yml b/ci/requirements-py3.7.yml
@@ -7,7 +7,6 @@ dependencies:
     - cython
     - ephem
     - h5py
-    - netcdf4
     - numba
     - numpy >= 1.16.0
     - pandas >= 0.25.0
@@ -23,7 +22,6 @@ dependencies:
     - pytz
     - requests
     - scipy >= 1.4.0
-    - siphon  # conda-forge
     - statsmodels
     - pip:
         - nrel-pysam>=2.0

diff --git a/ci/requirements-py3.8.yml b/ci/requirements-py3.8.yml
@@ -7,7 +7,6 @@ dependencies:
     - cython
     - ephem
     - h5py
-    - netcdf4
     - numba
     - numpy >= 1.16.0
     - pandas >= 0.25.0
@@ -23,7 +22,6 @@ dependencies:
     - pytz
     - requests
     - scipy >= 1.4.0
-    - siphon  # conda-forge
     - statsmodels
     - pip:
         - nrel-pysam>=2.0

diff --git a/ci/requirements-py3.9.yml b/ci/requirements-py3.9.yml
@@ -7,7 +7,6 @@ dependencies:
     - cython
     - ephem
     - h5py
-    - netcdf4
     - numba
     - numpy >= 1.16.0
     - pandas >= 0.25.0

diff --git a/codecov.yml b/codecov.yml
@@ -3,7 +3,7 @@ codecov:
     require_ci_to_pass: no
 
 # "flags" are used to identify subsets of the overall codebase when calculating coverage.
-# Currently used for "remote_data" (pvlib.iotools & forecast) and "core" (everything else).
+# Currently used for "remote_data" (pvlib.iotools) and "core" (everything else).
 # Because we only run the remote_data tests sometimes, we need to split it out so that
 # codecov doesn't report a big drop in coverage when we don't run them.
 # We also use "carryforward: true" so that, when we don't run remote_data tests, the last
@@ -16,16 +16,12 @@ flags:
       - pvlib/
       - '!pvlib/iotools/'
       - '!pvlib/tests/iotools/'
-      - '!pvlib/forecast.py'
-      - '!pvlib/tests/test_forecast.py'
     carryforward: false
 
   remote-data:
     paths:
       - pvlib/iotools/
       - pvlib/tests/iotools
-      - pvlib/forecast.py
-      - pvlib/tests/test_forecast.py
     carryforward: true  # if not run, use coverage from previous commit
 
 
@@ -53,15 +49,13 @@ coverage:
         paths:
           - 'pvlib/tests/.*'
           - '!pvlib/tests/iotools/.*'
-          - '!pvlib/tests/test_forecast.py'
         flags:
           - core
 
       tests-remote-data:
         target: 95%
         paths:
           - 'pvlib/tests/iotools/.*'
-          - 'pvlib/tests/test_forecast.py'
         flags:
           - remote-data
 

diff --git a/docs/sphinx/source/reference/forecasting.rst b/docs/sphinx/source/reference/forecasting.rst
diff --git a/docs/sphinx/source/reference/index.rst b/docs/sphinx/source/reference/index.rst
@@ -16,7 +16,6 @@ API reference
    effects_on_pv_system_output/index
    tracking
    iotools
-   forecasting
    modelchain
    bifacial
    scaling