Todo project Edit , Updating a completed task and Clear all completed tasks unit test #8
Conversation
There was a problem hiding this comment.
Hi @pushkar1995,
STATUS: CHANGES REQUIRED ♻️ ♻️
Good job so far!
There are some issues that you still need to work on to go to the next project but you are almost there!
Highlights
- All linter checks are passing ✔️ ✔️
- Your PR is professional 👍 👍
- Good job adding tests to your project 👏
Required Changes ♻️
Check the comments under the review.
Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
src/modules/edit.test.js
Outdated
| import { editTask, taskStatusUpdate, clearCompleted } from './EditTest.js'; | ||
|
|
||
| describe('Testing editing and updating', () => { | ||
| let tasks; | ||
|
|
||
| beforeEach(() => { | ||
| tasks = [{ | ||
| description: 'This is the test task', | ||
| completed: false, | ||
| index: 1, | ||
| }]; | ||
| }); | ||
|
|
||
| test('Editing one item of the list', () => { | ||
| editTask(tasks, 0, 'Testing'); | ||
| expect(tasks).toEqual([{ description: 'Testing', completed: false, index: 1 }]); | ||
| }); | ||
|
|
||
| test('Task Status Update of one item from the list', () => { | ||
| taskStatusUpdate(tasks, 0); | ||
| expect(tasks[0].completed).toEqual(true); | ||
| }); | ||
|
|
||
| test('Clear all completed tasks from the list', () => { | ||
| tasks.push( | ||
| { description: 'Testing', completed: false, index: 2 }, | ||
| { description: 'Another Test', completed: true, index: 3 }, | ||
| ); | ||
| taskStatusUpdate(tasks, 0); | ||
| tasks = clearCompleted(tasks); | ||
| expect(tasks).toEqual([{ description: 'Testing', completed: false, index: 0 }]); | ||
| }); | ||
| }); |
There was a problem hiding this comment.
- Good job done so far, Though I see that you understand the concept of testing, according to the project requirements, please test the functions from your application. I see that you created similar functions in your
EditTest.jsfile. But I suggest that since you already have these functions in yourEditTask.js, clearCompletedTask.js and TaskStatusUpdate.jsfiles. Please import these functions and test them 🙏
There was a problem hiding this comment.
Hi 👋 @pushkar1995, @Arch-Noize,
Your project is complete! There is nothing else to say other than... it's time to merge it 
Congratulations! 🎉
Highlights
👍 You did well to test other functions such as clearing the completed tasks as requested by the previous reviewer.
Optional suggestions
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers, and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
In this branch, we implemented Jest unit testing. This time, we included