This repository has been archived by the owner on Oct 4, 2020. It is now read-only.
choose: the set of all subsets of specified size #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hdgarrood
reviewed
Jan 16, 2018
| @@ -176,3 +177,11 @@ intersection s1 s2 = fromFoldable $ runPure (runSTArray (emptySTArray >>= inters | |||
| LT -> pure $ Loop {a: l + 1, b: r} | |||
| GT -> pure $ Loop {a: l, b: r + 1} | |||
| else pure $ Done acc | |||
|
|
|||
| -- | The set of all subsets of specified size | |||
There was a problem hiding this comment.
I think the following are missing:
- Running time, preferably in big O
- An example in the docs
- At least one full sentence in the docs - this seems a little unnecessarily abridged. In particular, what happens when the provided
Intargument is larger than the size of the provided set? - Handling for the case where a negative
Intargument is supplied.
There was a problem hiding this comment.
Yes, you're absolutely right. I threw both this and powerSet over the fence a bit prematurely. I'll fix them up.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.