Skip to content
This repository has been archived by the owner on Aug 4, 2023. It is now read-only.

Update to purescript 0.7 #2

Merged
merged 11 commits into from
Aug 11, 2015
Merged

Update to purescript 0.7 #2

merged 11 commits into from
Aug 11, 2015

Conversation

paf31
Copy link
Contributor

@paf31 paf31 commented Jul 6, 2015

/cc @garyb @felixSchl

This is a minimal set of changes.

@felixSchl
Copy link
Contributor

I just cannot get this project to build after applying the patch. I take we have to upgrade gulp-purescript to it's purescript-0.7 compatible release and update our usage of it (the API has changed under our feet, also refer c45d0ba).

I took a quick stab at it but it winged that prelude was defined multiple times now?

@paf31
Copy link
Contributor Author

paf31 commented Jul 6, 2015

Did you clear out bower_components etc.? Does psc --version say 0.7?

@felixSchl
Copy link
Contributor

It says 0.6.8 because I have not npm install -g-ed it yet. That brings up an interesting issue though, our refs are not buildable standalone because they rely on some omnipresent version of purescript without specifying the compiler version they require. I wonder if gulp purescript gives us the chance to choose a version to use for the compiler.

@felixSchl
Copy link
Contributor

I guess this would also be pending a purescript 0.7 release to npm.

@felixSchl
Copy link
Contributor

I filed an issue for this: purescript-deprecated/gulp-purescript#50

@paf31
Copy link
Contributor Author

paf31 commented Jul 6, 2015

I don't use gulp so I'm not certain about how to fix the issues you're seeing, but I know you need to have psc 0.7 on your PATH.

@garyb
Copy link
Member

garyb commented Jul 7, 2015

👍 for the changes.

@paf31
Copy link
Contributor Author

paf31 commented Jul 7, 2015

Can I merge this then? Seems the gulp issue is unrelated.

@felixSchl
Copy link
Contributor

Personally I would wait until it's in a compilable state before merging into master. I am going to look into this. Just not too sure when, my second daughter just got born hours ago :) either way my vote is to keep this on a branch until ready. @garyb what do u reckon?

@paf31
Copy link
Contributor Author

paf31 commented Jul 7, 2015

Congratulations :D

@garyb
Copy link
Member

garyb commented Jul 7, 2015

Congrats! 🎉

@felixSchl felixSchl changed the title Take 2 Update to purescript 0.7 Jul 15, 2015
@felixSchl
Copy link
Contributor

I've made a couple of changes, including an update to the gulpfile, the way the docs are generated and so on. I made sure to create atomic commits so it's easier to get an overview. We can squash before merge if so desired. It runs fine after git stash && git clean -fdx && npm install && bower install && gulp example, but I would appreciate a review if there's something we missed?

@paf31
Copy link
Contributor Author

paf31 commented Aug 3, 2015

Looks fine, but I don't use gulp so I don't feel strongly :)

@paf31
Copy link
Contributor Author

paf31 commented Aug 11, 2015

Can we get this merged then?

@felixSchl
Copy link
Contributor

I don't see why not, I will take care of it.

@felixSchl felixSchl merged commit eff769b into master Aug 11, 2015
felixSchl added a commit that referenced this pull request Aug 11, 2015
@paf31 paf31 deleted the 0.7-take-2 branch August 11, 2015 21:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants