Merge pull request #838 from puremourning/fix-add-watch-traceback

Fix traceback when adding a watch without current frame
puremourning · Feb 15, 2024 · 98867a9 · 98867a9
2 parents 6ff7f00 + 4b3cd38
commit 98867a9
Show file tree

Hide file tree

Showing 4 changed files with 59 additions and 13 deletions.
diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml
@@ -114,7 +114,9 @@ jobs:
       matrix:
         runtime:
           - vim
-          - nvim
+          # - nvim ; MacOS in GHA is so slow, this seems to cause lots of
+          # flakiness for neovim and I have like 0 patience with trying to
+          # understand why.
     steps:
     - uses: actions/checkout@v3
 

diff --git a/.mergify.yml b/.mergify.yml
@@ -9,7 +9,7 @@ queue_rules:
       - status-success=Linux (vim)
       - status-success=Linux (nvim)
       - status-success=MacOS (vim)
-      - status-success=MacOS (nvim)
+      #- status-success=MacOS (nvim)
 
 pull_request_rules:
   - name: Merge owner PR when all checks passed
@@ -26,7 +26,7 @@ pull_request_rules:
       - status-success=Linux (vim)
       - status-success=Linux (nvim)
       - status-success=MacOS (vim)
-      - status-success=MacOS (nvim)
+      #- status-success=MacOS (nvim)
     actions: &merge-actions
       queue:
         method: merge
@@ -61,7 +61,7 @@ pull_request_rules:
       - status-success=Linux (vim)
       - status-success=Linux (nvim)
       - status-success=MacOS (vim)
-      - status-success=MacOS (nvim)
+      #- status-success=MacOS (nvim)
     actions:
       <<: *merge-actions
       comment:

diff --git a/python3/vimspector/variables.py b/python3/vimspector/variables.py
@@ -176,6 +176,10 @@ def SetCurrentFrame( self, connection, frame ):
     elif self.connection != connection:
       return
 
+    if frame is None:
+      # Evaluation in a context where there is no current frame.
+      return
+
     self.expression[ 'frameId' ] = frame[ 'id' ]
 
   @staticmethod

diff --git a/tests/variables.test.vim b/tests/variables.test.vim
@@ -19,15 +19,15 @@ function! ConsoleBufferName()
 endfunction
 
 function! s:StartDebugging( ... )
-  if a:0 == 0
-    let config = #{
-          \   fn: s:fn,
-          \   line: 23,
-          \   col: 1,
-          \   launch: #{ configuration: 'run' }
-          \ }
-  else
-    let config = a:1
+  let config = #{
+        \   fn: s:fn,
+        \   line: 23,
+        \   col: 1,
+        \   launch: #{ configuration: 'run' }
+        \ }
+
+  if a:0 > 0
+    call extend( config, a:1 )
   endif
 
   execute 'edit' config.fn
@@ -1265,3 +1265,43 @@ EOF
   call vimspector#test#setup#Reset()
   %bwipe!
 endfunction
+
+function! Test_WatchAfterExit()
+  call s:StartDebugging( #{
+        \ col: v:null,
+        \ line: 3,
+        \ fn: 'testdata/cpp/simple/tiny.c',
+        \ launch: #{ configuration: 'CodeLLDB' }
+        \ } )
+
+  call vimspector#Continue()
+  call WaitForAssert( {->
+        \   AssertMatchList(
+        \     [
+        \         '+ Thread [0-9]\+: .* (terminated)',
+        \     ],
+        \     GetBufLine( winbufnr( g:vimspector_session_windows.stack_trace ),
+        \                 1,
+        \                 '$' )
+        \   )
+        \ } )
+
+  " Add a wtch
+  call vimspector#AddWatch( 'res' )
+
+  call WaitForAssert( {->
+        \   AssertMatchList(
+        \     [
+        \       'Watches: ----',
+        \       'Expression: res',
+        \       ' \*- Result: .*',
+        \     ],
+        \     getbufline( winbufnr( g:vimspector_session_windows.watches ),
+        \                 1,
+        \                 '$' )
+        \   )
+        \ } )
+
+  call vimspector#test#setup#Reset()
+  %bwipe!
+endfunction