Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(PA-5013) Add Red Hat 9 (ARM64) to the puppet_agent module task #675

Merged
merged 1 commit into from
Oct 16, 2023
Merged

(PA-5013) Add Red Hat 9 (ARM64) to the puppet_agent module task #675

merged 1 commit into from
Oct 16, 2023

Conversation

skyamgarp
Copy link
Contributor

@skyamgarp skyamgarp commented Oct 12, 2023 •
edited
Loading

  • Specified 'latest' to install el-9-aarch64 from nightlies, since official packages not available yet.
  • Updated MacOS13 first available version and use the released agent build instead of nightlies.

@skyamgarp skyamgarp requested review from bastelfreak and a team as code owners October 12, 2023 12:48
@skyamgarp skyamgarp marked this pull request as draft October 12, 2023 12:49
@skyamgarp skyamgarp marked this pull request as ready for review October 12, 2023 14:38
amitkarsale
amitkarsale approved these changes Oct 13, 2023
View reviewed changes
Copy link
Contributor

@amitkarsale amitkarsale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@skyamgarp
Copy link
Contributor Author

@joshcooper Can you please review this?

bastelfreak
bastelfreak reviewed Oct 13, 2023
View reviewed changes
task_spec/spec/acceptance/init_spec.rb
@@ -69,7 +71,7 @@ def log_output_errors(result)
# else
# end
case target_platform
when %r{osx-13}
when %r{el-9-aarch64}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this changed / why do you remove osx13 here? That change isn't reflected in the PR title

Copy link
Contributor Author

@skyamgarp skyamgarp Oct 13, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so before release we updated it to use agent from nightlies but now we have agent released like we changed the version here. I have updated it with redhat9-aarch64 now as we are yet to release it. Yes and the jira is for adding redhat9 so didn't mention it PR title.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For future, it'd be good to separate out the "adding rhel9 arm" versus "dropping the special case for osx 13" into separate commits.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I agree.

@skyamgarp skyamgarp merged commit 39d8ab9 into puppetlabs:main Oct 16, 2023
17 checks passed
@skyamgarp skyamgarp deleted the PA-5013 branch October 16, 2023 15:12
@mhashizume mhashizume added the enhancement New feature or request label Oct 26, 2023
@skyamgarp skyamgarp mentioned this pull request Mar 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bastelfreak bastelfreak bastelfreak left review comments

@joshcooper joshcooper joshcooper left review comments

@amitkarsale amitkarsale amitkarsale approved these changes

@donoghuc donoghuc donoghuc approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@skyamgarp @bastelfreak @joshcooper @amitkarsale @donoghuc @mhashizume