Match allowed datatypes to yumrepo skip_if_unavailable support #672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastelfreak
approved these changes
Sep 27, 2023
|
Hmm... unless I'm looking in the wrong spot the "PA" project is marked as archived and I cannot create issues there to reference in the commit message (per the error in Static Code Analysis check). |
|
Thanks for this @seanmil . Since this is just a minor correction, could you add "(maint)" to the beginning of your commit summary to get it to pass the static code analysis check? |
mhashizume
approved these changes
Sep 27, 2023
seanmil
force-pushed
the
expand_skip_if_unavailable_type
branch
from
9f9a02a
to
3c5206f
Compare
|
Ah sorry one more thing, could you regenerate REFERENCE.md with your changes? You should be able to run Thanks again! |
In PR puppetlabs#663 an overly strict datatype was set for the skip_if_unavailable parameter. The yumrepo type supports a variety of string values and boolean values.
seanmil
force-pushed
the
expand_skip_if_unavailable_type
branch
from
3c5206f
to
7e3f826
Compare
mhashizume
added
the
maintenance
mhashizume
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In PR #663 an overly strict datatype was set for the skip_if_unavailable parameter. The yumrepo type supports a variety of string values and boolean values.