Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(PA-5691) Add missing puppet settings to config_setting.pp #661

Merged

Conversation

AriaXLi
Copy link
Contributor

@AriaXLi AriaXLi commented Aug 18, 2023

This commit updates config_setting.pp and adds any missing puppet 7.x and 8.x settings. Some puppet 8.x specific settings, like ca_refresh_interval are being added. The agent will ignore any settings it does not understand/support.

This commit updates config_setting.pp and adds any missing puppet 7.x and 8.x
settings. Some puppet 8.x specific settings, like `ca_refresh_interval` are
being added. The agent will ignore any settings it does not understand/support.
@AriaXLi AriaXLi requested a review from a team as a code owner August 18, 2023 17:19
@AriaXLi
Copy link
Contributor Author

AriaXLi commented Aug 18, 2023

puppet on  main [$?] via 💎 v3.1.0
❯ bundle exec puppet doc -r configuration | grep '### ' > all_puppet_config_settings.txt

I edited all_puppet_config_settings a bit so it matches the formatting of config_setting.pp then compared the differences:

puppetlabs-puppet_agent on  main [?] via 💎 v3.1.0 took 3m44s
❯ diff types/config_setting.pp types/all_puppet_config_settings.pp
6a7
>   allow_pson_serialization,
15a17
>   ca_refresh_interval,
64d65
<   environment_timeout_mode,
66a68
>   exclude_unchanged_resources,
70d71
<   facterng,
77,78d77
<   func3x_check,
<   future_features,
85a85
>   hostcert_renewal_interval,
102a103
>   include_legacy_facts,
122a124
>   location_trusted,
145d146
<   node_name,
163a165
>   preprocess_deferred,
169a172
>   publicdir,
173a177
>   report_configured_environmentpath,
180c184
---
<   rest_authconfig,
193a197
>   settings_catalog,
201d204
<   ssl_client_ca_auth,
205d207
<   ssl_server_ca_auth,
216d217
<   strict_hostname_checking,
228a230
>   use_last_environment,
237c239,240
<   yamldir
---
>   write_catalog_summary,
>   yamldir,

@tvpartytonight tvpartytonight merged commit ac83d4f into puppetlabs:main Aug 23, 2023
16 checks passed
@AriaXLi AriaXLi added the maintenance Maintenance chores are typically excluded from changelogs label Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Maintenance chores are typically excluded from changelogs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants