Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(PE-36366) Update PEADM with 2023.5 support #403

Merged
merged 1 commit into from
Nov 7, 2023
Merged

(PE-36366) Update PEADM with 2023.5 support #403

merged 1 commit into from
Nov 7, 2023

Conversation

Jo-Lillie
Copy link
Contributor

@Jo-Lillie Jo-Lillie commented Nov 7, 2023 •
edited
Loading

Summary

Update to 2023.5 support

Additional Context

Add any additional context about the problem here.

Related Issues (if any)

Mention any related issues or pull requests.

Checklist

  • 🟢 Spec tests.
  • 🟢 Acceptance tests.

Changes include test coverage?

  • Yes
  • Not needed

Have you updated the documentation?

  • Yes, I've updated the appropriate docs
  • Not needed

@Jo-Lillie Jo-Lillie requested review from a team as code owners November 7, 2023 11:05
@CLAassistant
Copy link

CLAassistant commented Nov 7, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

CoMfUcIoS
CoMfUcIoS approved these changes Nov 7, 2023
View reviewed changes
Copy link
Contributor

@CoMfUcIoS CoMfUcIoS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. there is a known issue with our ci and centos 7 which we are actively looking into.

@Jo-Lillie Jo-Lillie merged commit bddd9a5 into puppetlabs:main Nov 7, 2023
49 of 51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CoMfUcIoS CoMfUcIoS CoMfUcIoS approved these changes

@ragingra ragingra Awaiting requested review from ragingra

Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Jo-Lillie @CLAassistant @CoMfUcIoS