peadm::install: Depend code-manager setup on r10k remote presence, not r10k ssh key #401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t r10k ssh key We've logic in place that checks if the user provided an r10k remote key and then automatically enable code-manager. This doesn't make sense because the key is optional. We need to depend on a r10k URL. The URL can be an absolute path to a local repo or an https url, both don't require a remote key. Fixes a bug I introcued in https://github.com/puppetlabs/puppetlabs-peadm/pull/352/files#r1373941616
Magisus
approved these changes
Oct 27, 2023
|
Thanks for the quick response to this! I noticed it because the CD4PE team is using |
ragingra
approved these changes
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've logic in place that checks if the user provided an r10k remote key and then automatically enable code-manager. This doesn't make sense because the key is optional. We need to depend on a r10k URL. The URL can be an absolute path to a local repo or an https url, both don't require a remote key.
Fixes a bug I introcued in https://github.com/puppetlabs/puppetlabs-peadm/pull/352/files#r1373941616