Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(#366) Bump inifile and stdlib #367

Merged
merged 1 commit into from
Jun 27, 2023
Merged

(#366) Bump inifile and stdlib #367

merged 1 commit into from
Jun 27, 2023

Conversation

CoMfUcIoS
Copy link
Contributor

@CoMfUcIoS CoMfUcIoS commented Jun 27, 2023 •
edited
Loading

We need to bump inifile so it will use latest stdlib

@CoMfUcIoS CoMfUcIoS requested review from a team as code owners June 27, 2023 09:03
@CoMfUcIoS CoMfUcIoS added the bug label Jun 27, 2023
@CoMfUcIoS CoMfUcIoS linked an issue Jun 27, 2023 that may be closed by this pull request
module incorrectly states compatibility with stdlib v6 #366
Closed
@MartyEwings MartyEwings self-requested a review June 27, 2023 09:10
MartyEwings
MartyEwings requested changes Jun 27, 2023
View reviewed changes
Copy link
Contributor

@MartyEwings MartyEwings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need to lock stdlib to more than or equal to 8.6

  "name": "puppetlabs/stdlib",
  "version_requirement": ">= 8.6.0 < 10.0.0"

since the namespace functions only appeared in that version

@CoMfUcIoS CoMfUcIoS changed the title (MAINT) Bump inifile (MAINT) Bump inifile and stdlib Jun 27, 2023
@CoMfUcIoS CoMfUcIoS changed the title (MAINT) Bump inifile and stdlib (#366) Bump inifile and stdlib Jun 27, 2023
@CoMfUcIoS CoMfUcIoS merged commit 131051c into puppetlabs:main Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartyEwings MartyEwings MartyEwings approved these changes

@ragingra ragingra ragingra approved these changes

Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

module incorrectly states compatibility with stdlib v6
3 participants
@CoMfUcIoS @ragingra @MartyEwings