Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(maint) Update pip provider regex #9481

Conversation

cthorn42
Copy link
Collaborator

When searching for versions of a Pip module a regex we depend on needs to be updated to work with Pip version 24.

When searching for versions of a Pip module a regex we depend on needs
to be updated to work with Pip version 24.
@cthorn42 cthorn42 requested a review from a team as a code owner September 12, 2024 21:07
@cthorn42 cthorn42 added the bug Something isn't working label Sep 12, 2024
@cthorn42
Copy link
Collaborator Author

Tested this on Ubuntu 2404 x86_64 with a Pip version 24.2 and on Ubuntu 1804 x86_64 with a Pip version 9.0.1, and with this change puppet-agent was able to apply this catalog:

package { 'python3-pip':
  ensure => latest,
 }

package { pandas:
   ensure  => latest,
   provider => 'pip3',
  }

With this change on both OSes and both versions of Pip I was able to install pandas.

@joshcooper
Copy link
Contributor

joshcooper commented Sep 12, 2024

Could you add a link to this PR about where the regex came from?

@cthorn42
Copy link
Collaborator Author

The regex we're switching to here, 9!0dev0+x, comes from Github user notatallshaw, as suggested in this thread: pypa/pip#12852 (comment).

@cthorn42 cthorn42 merged commit a1ffb1b into puppetlabs:main Sep 13, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants